Remove writable JSON DOM #34099
Merged
Remove writable JSON DOM #34099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
approved these changes
Mar 25, 2020
ahsonkhan
approved these changes
Mar 26, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonElement.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonElement.cs
Show resolved
Hide resolved
joperezr
approved these changes
Mar 26, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation in #30436, this PR removes the writable JSON dom.
Shipping a writable dom is on the roadmap for JSON, but is not prioritized at the moment. #30436 (comment) outlines the next steps, which includes responding to UX study feedback and further design + API review. Iteration on this feature will probably be in a feature branch.
cc @ericstj, @joperezr, @ahsonkhan, @stephentoub