Move some Mono corelib strings to resources/nameof #34089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
marek-safar
approved these changes
Mar 25, 2020
|
@jaredpar thoughts? |
|
@danmosemsft looks like #34015 is impacting CI builds now too as well as official. |
stephentoub
reviewed
Mar 26, 2020
...ono/netcore/System.Private.CoreLib/src/System/Reflection/Emit/CustomAttributeBuilder.Mono.cs
Show resolved
Hide resolved
stephentoub
reviewed
Mar 26, 2020
| @@ -415,7 +415,7 @@ public override Type GetType(string className, bool throwOnError, bool ignoreCas | |||
| if (className == null) | |||
| throw new ArgumentNullException(nameof(className)); | |||
| if (className.Length == 0) | |||
| throw new ArgumentException("className"); | |||
| throw new ArgumentException(nameof(className)); | |||
There was a problem hiding this comment.
The first argument to ArgumentException is a message, not the parameter name (unfortunately).
There was a problem hiding this comment.
Literally 20 minutes ago I was pointing out on the analyzers issue that we had several instances of this mistake. That's my excuse.
stephentoub
approved these changes
Mar 26, 2020
vargaz
approved these changes
Mar 26, 2020
|
Unrelated test failures . Perf failure on other jobs also |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #34056