Fix the operands of NI_AVX512F_TernaryLogic during lowering #107813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
3 tasks
This reverts commit 5b01643.
|
@tannergooding @BruceForstall PTAL. We want to merge before 4pm today. |
tannergooding
approved these changes
Sep 16, 2024
| [Fact] | ||
| public static void TestEntryPoint() | ||
| { | ||
| try |
There was a problem hiding this comment.
This should rather be checking if (Avx512F.IsSupported), rather than doing try/catch, no?
There was a problem hiding this comment.
ah, I misread the error of a different issue about "NullReferenceException". Will fix it.
This reverts commit 3319875.
|
/azp run Fuzzlyn |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10890038223 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not correctly translating the logical operation into control word leading to assert getting hit during containment.
Fixes: #107587
Fixes: #107324