Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64/Sve: Remove entries of SVE APIs take 32-bit address #107758

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

kunalspathak
Copy link
Member

We have done it in the past because we do not have good way of validating them. There were few left over that I commented in this PR and disabled the tests for them.

Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@kunalspathak
Copy link
Member Author

@dotnet/arm64-contrib

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick parse locally, and all the Gather* APIs with a svuint32_t argument are disabled. LGTM

@kunalspathak
Copy link
Member Author

/ba-g failure seems to be timeout

@kunalspathak kunalspathak merged commit c8ae841 into dotnet:main Sep 13, 2024
144 of 149 checks passed
@kunalspathak
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10842874058

Copy link
Contributor

@kunalspathak backporting to release/9.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Remove entry of APIs because of #103297
Using index info to reconstruct a base tree...
M	src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
M	src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
CONFLICT (content): Merge conflict in src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.cs
Auto-merging src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
CONFLICT (content): Merge conflict in src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve.PlatformNotSupported.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove entry of APIs because of #103297
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

@kunalspathak an error occurred while backporting to release/9.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Sep 13, 2024
)

* Remove entry of APIs because of dotnet#103297

* comment out the test cases for unsupported APIs
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Sep 13, 2024
)

* Remove entry of APIs because of dotnet#103297

* comment out the test cases for unsupported APIs
akoeplinger added a commit to ViktorHofer/runtime that referenced this pull request Sep 13, 2024
jeffschwMSFT added a commit that referenced this pull request Sep 13, 2024
…107780)

* Remove entry of APIs because of #103297

* comment out the test cases for unsupported APIs

Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
)

* Remove entry of APIs because of dotnet#103297

* comment out the test cases for unsupported APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants