Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test bug in FileSystem.Tests #107696

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix test bug in FileSystem.Tests #107696

merged 1 commit into from
Sep 12, 2024

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Sep 11, 2024

Fixes #107636.

@jozkee jozkee added this to the 10.0.0 milestone Sep 11, 2024
@jozkee jozkee self-assigned this Sep 11, 2024
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jozkee !

@jozkee
Copy link
Member Author

jozkee commented Sep 12, 2024

/ba-g System.Collections.Specialized.Tests dead-lettered.

@jozkee jozkee merged commit 01ac168 into dotnet:main Sep 12, 2024
79 of 85 checks passed
@jozkee jozkee deleted the io_testbug branch September 12, 2024 21:15
@adamsitnik
Copy link
Member

Should we backport it to 9.0 branch?

@jozkee
Copy link
Member Author

jozkee commented Sep 13, 2024

@saitama951 doesn't seem to be using the 9.0 branch and looks like we don't have any CI tests running as root so it won't affect CI until we do, that's also why this wasn't caught.

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test cases System.IO.FileSystem
3 participants