Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] [mono] Revert "don't define HAS_CUSTOM_BLOCKS on mono (#106764)" #107675

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 11, 2024

Backport of #107558 to release/9.0

/cc @matouskozak

Customer Impact

  • Customer reported
  • Found internally

The #106801 caused significant improvements for MonoJIT but introduced unexpected regressions for MonoAOT/MonoInterpreter described at #107308 (comment). We decided that the safest approach for .NET 9 is to keep MonoJIT regressed and do not introduce new regressions to MonoAOT and MonoInterpreter.

Regression

  • Yes
  • No

Found using Performance measurements on dotnet/runtime main.

Testing

Revert of #106801, we expect to get to the state before the original commit.

Risk

Low: this is a revert of previous backport #106801.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

@matouskozak matouskozak added this to the 9.0.0 milestone Sep 11, 2024
@vitek-karas vitek-karas added the Servicing-consider Issue for next servicing release review label Sep 11, 2024
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and this can be merged when ready

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 11, 2024
@matouskozak
Copy link
Member

cc: @carlossanlop it's ready to merge

@carlossanlop carlossanlop merged commit 593af2b into release/9.0 Sep 12, 2024
149 of 155 checks passed
@carlossanlop carlossanlop deleted the backport/pr-107558-to-release/9.0 branch September 12, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Memory Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants