[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

tomeksowi · 2024-09-03T08:39:52Z

Properly implements the transfer of arguments between integer and hardware floating-point calling conventions (i.e. lowering and delowering) in shuffling thunks. The hitherto implementation was lacking in several ways:

used fld (8-byte) to shuffle float from stack to register, which is wrong because the stack slot is not NaN-boxed
did not support FP structs passed in one stack slot
did not respect size and offsets of FP struct fields in general
did not support shuffling stack slots to the right (when the delowered FP struct was larger than the lowered one but there was another lowering)
did not support the case when the shuffling thunk must allocate stack space (the above case but without the second lowering)

The new implementation does away with the omnibus loop in StubLinkerCPU::EmitShuffleThunk in favor of tighter case-by-case loops. That way shuffling all within integer calling convention (vast majority of cases) is simple and the more involved cases with calling convention transfers are complete while still not needing all-out graph sorting.

Note: this PR is about correctness, optimization TODOs will not be pursued here.

Stems from #101796, part of #84834, cc @dotnet/samsung

…nstead of an omnibus loop handling ShuffleEntries

…pStructs. EmptyStructs test passes except for ShufflingThunk_FloatEmptyShort_DoubleFloatNestedEmpty_RiscV

…Regressions/coreclr/GitHub_16833/Test16833

…he key points first, which simplifies code and solves some corner cases e.g. where we can't assume struct stack size by checking the size + offset of the last field

risc-vv · 2024-09-09T14:10:57Z

1c7b0b1 is being scheduled for building and testing

GIT: 1c7b0b15e6ec4155c85faf183b26458f60098f63
REPO: tomeksowi/runtime
BRANCH: fp-structs-shuffling-thunks

Release-build FAILED

buildinfo.json
${{details}}

risc-vv · 2024-09-10T06:51:00Z

Release-CLR-build FAILED

buildinfo.json
${{details}}

risc-vv · 2024-09-10T11:01:09Z

Release-CLR-build FAILED

buildinfo.json
${{details}}

RISC-V Release-CLR-VF2: 9408 / 9425 (99.82%)

=======================
      passed: 9408
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9532
 TOTAL tests: 9532
   REAL time: 2h 57min 56s 199ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 0 / 257 (0.00%)

=======================
      passed: 0
      failed: 0
     skipped: 0
      killed: 257
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 41s 701ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: 7f81c079ff36820977523c57dd151d4ca90f5f97
CI: eb4e1790217a2d5352c9c1cbdb42afcfed31798d
REPO: tomeksowi/runtime
BRANCH: fp-structs-shuffling-thunks
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

risc-vv · 2024-09-10T13:51:08Z

RISC-V Release-CLR-QEMU: 9408 / 9425 (99.82%)

=======================
      passed: 9408
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9532
 TOTAL tests: 9532
   REAL time: 57min 58s 419ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 254 / 257 (98.83%)

=======================
      passed: 254
      failed: 0
     skipped: 0
      killed: 3
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 10min 25s 434ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: 74dcd7c04eae0ae0d6638f35eb676ae073fcb034
CI: eb4e1790217a2d5352c9c1cbdb42afcfed31798d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9408 / 9425 (99.82%)

=======================
      passed: 9408
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9532
 TOTAL tests: 9532
   REAL time: 2h 57min 56s 199ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 254 / 257 (98.83%)

=======================
      passed: 254
      failed: 0
     skipped: 0
      killed: 3
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 21min 28s 182ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: 74dcd7c04eae0ae0d6638f35eb676ae073fcb034
CI: eb4e1790217a2d5352c9c1cbdb42afcfed31798d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-QEMU: 9408 / 9425 (99.82%)

=======================
      passed: 9408
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9532
 TOTAL tests: 9532
   REAL time: 47min 38s 125ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 254 / 257 (98.83%)

=======================
      passed: 254
      failed: 0
     skipped: 0
      killed: 3
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 10min 25s 434ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: 74dcd7c04eae0ae0d6638f35eb676ae073fcb034
CI: eb4e1790217a2d5352c9c1cbdb42afcfed31798d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9409 / 9425 (99.83%)

=======================
      passed: 9409
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9532
 TOTAL tests: 9532
   REAL time: 3h 0min 35s 802ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 254 / 257 (98.83%)

=======================
      passed: 254
      failed: 0
     skipped: 0
      killed: 3
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 21min 28s 182ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: 74dcd7c04eae0ae0d6638f35eb676ae073fcb034
CI: eb4e1790217a2d5352c9c1cbdb42afcfed31798d
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

am11 · 2024-09-10T14:42:00Z

Note: this PR is about correctness

Are there disabled tests which can be enabled with these fixes?

tomeksowi · 2024-09-10T15:54:52Z

Are there disabled tests which can be enabled with these fixes?

I covered these fixes with new tests added with this PR.

Most ABI-related tests tend to cover corner-cases on existing platforms. New platforms will be somewhat undertested and should fill these gaps.

risc-vv · 2024-09-11T10:25:56Z

RISC-V Release-CLR-QEMU: 9409 / 9426 (99.82%)

=======================
      passed: 9409
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9533
 TOTAL tests: 9533
   REAL time: 57min 57s 115ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 254 / 257 (98.83%)

=======================
      passed: 254
      failed: 0
     skipped: 0
      killed: 3
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 10min 45s 270ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: c5f72c6b39ff444560b35700375bc9ac39b47307
CI: dc91782e57589d0840511cf3b2db259f5b9cd49a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9409 / 9426 (99.82%)

=======================
      passed: 9409
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9533
 TOTAL tests: 9533
   REAL time: 3h 3min 5s 972ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 254 / 257 (98.83%)

=======================
      passed: 254
      failed: 0
     skipped: 0
      killed: 3
------------------------
  TOTAL libs: 257
 TOTAL tests: 257
   REAL time: 22min 11s 405ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: c5f72c6b39ff444560b35700375bc9ac39b47307
CI: dc91782e57589d0840511cf3b2db259f5b9cd49a
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ && cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

src/coreclr/vm/comdelegate.cpp

src/coreclr/vm/riscv64/stubs.cpp

…egate code paths

…ia buffer

risc-vv · 2024-09-16T11:10:56Z

RISC-V Release-CLR-QEMU: 9413 / 9430 (99.82%)

=======================
      passed: 9413
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9537
 TOTAL tests: 9537
   REAL time: 46min 24s 675ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 588101 / 619248 (94.97%)

=======================
      passed: 588101
      failed: 327
     skipped: 1581
      killed: 30820
------------------------
  TOTAL libs: 257
 TOTAL tests: 620829
   REAL time: 2h 23min 13s 194ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and links

GIT: 268a28b80bc8511887aeceb36e20977907e87c07
CI: d97c78c985318fc22a1d9753bda52b54d6c900ec
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

RISC-V Release-CLR-VF2: 9414 / 9430 (99.83%)

=======================
      passed: 9414
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9537
 TOTAL tests: 9537
   REAL time: 3h 3min 3s 495ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 482499 / 535927 (90.03%)

=======================
      passed: 482499
      failed: 26
     skipped: 1457
      killed: 53402
------------------------
  TOTAL libs: 257
 TOTAL tests: 537384
   REAL time: 2h 28min 22s 511ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and links

GIT: 268a28b80bc8511887aeceb36e20977907e87c07
CI: d97c78c985318fc22a1d9753bda52b54d6c900ec
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

src/coreclr/vm/riscv64/stubs.cpp

…e to cover interleaving FP and int arguments

risc-vv · 2024-09-18T09:26:00Z

RISC-V Release-CLR-QEMU: 9414 / 9431 (99.82%)

=======================
      passed: 9414
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 46min 11s 520ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 608145 / 644894 (94.30%)

=======================
      passed: 608145
      failed: 317
     skipped: 1580
      killed: 36432
------------------------
  TOTAL libs: 257
 TOTAL tests: 646474
   REAL time: 2h 23min 30s 642ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9415 / 9431 (99.83%)

=======================
      passed: 9415
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 3h 8min 4s 565ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 458812 / 518194 (88.54%)

=======================
      passed: 458812
      failed: 31
     skipped: 1466
      killed: 59351
------------------------
  TOTAL libs: 257
 TOTAL tests: 519660
   REAL time: 2h 57min 9s 821ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9415 / 9431 (99.83%)

=======================
      passed: 9415
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 3h 2min 37s 198ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 458812 / 518194 (88.54%)

=======================
      passed: 458812
      failed: 31
     skipped: 1466
      killed: 59351
------------------------
  TOTAL libs: 257
 TOTAL tests: 519660
   REAL time: 2h 57min 9s 821ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-QEMU: 9414 / 9431 (99.82%)

=======================
      passed: 9414
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 57min 58s 348ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 608145 / 644894 (94.30%)

=======================
      passed: 608145
      failed: 317
     skipped: 1580
      killed: 36432
------------------------
  TOTAL libs: 257
 TOTAL tests: 646474
   REAL time: 2h 23min 30s 642ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-QEMU: 9414 / 9431 (99.82%)

=======================
      passed: 9414
      failed: 2
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 57min 58s 348ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 574680 / 610512 (94.13%)

=======================
      passed: 574680
      failed: 324
     skipped: 1580
      killed: 35508
------------------------
  TOTAL libs: 257
 TOTAL tests: 612092
   REAL time: 2h 2min 42s 241ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9415 / 9431 (99.83%)

=======================
      passed: 9415
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 3h 2min 35s 56ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 458812 / 518194 (88.54%)

=======================
      passed: 458812
      failed: 31
     skipped: 1466
      killed: 59351
------------------------
  TOTAL libs: 257
 TOTAL tests: 519660
   REAL time: 2h 57min 9s 821ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9415 / 9431 (99.83%)

=======================
      passed: 9415
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9538
 TOTAL tests: 9538
   REAL time: 3h 2min 35s 56ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 507425 / 558222 (90.90%)

=======================
      passed: 507425
      failed: 21
     skipped: 1465
      killed: 50776
------------------------
  TOTAL libs: 257
 TOTAL tests: 559687
   REAL time: 3h 20min 33s 838ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 6c7e29f25e4adf3ddca12950cebe0d5dbad8afea
CI: 9d2fd18d83dc740f91e7224e77e6665c61d1a038
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

yurai007

As far I can tell generated assembly looks fine.

tomeksowi added 26 commits August 28, 2024 14:48

Log ShuffleEntries from GenerateShuffleArray

70cf57f

Add failing tests for passing FP structs through shuffling thunks

1377172

Report proper ShuffleEntries for lowered FP structs

1cec66b

Implement shuffling thunk generation in tighter, more focused loops i…

329321b

…nstead of an omnibus loop handling ShuffleEntries

Generate ShuffleEntries for delowered arguments

9a50786

Better ShuffleEntry mask names, one more bit for field offset

87c8397

Fix FpStruct for dst arg loc

8b3b470

Fold ShuffleEntry generation code for lowering and delowering FpStructs

1a14067

ShuffleEntry mask doc update

6fa6d18

Implement forward shuffling of floating registers and delowering of F…

114583a

…pStructs. EmptyStructs test passes except for ShufflingThunk_FloatEmptyShort_DoubleFloatNestedEmpty_RiscV

Fix shuffling of integer registers for member functions

331d77e

The delowered argument can also be put in the first stack slot

1d96d11

Stask shuffling after delowered argument doesn't start with 0. Fixes …

30edbc5

…Regressions/coreclr/GitHub_16833/Test16833

Code cleanup, fewer indents

a445275

Support second lowering

bec2d89

Remove unused CondCode

83dee89

Handle stack slot shuffling to the right

b1466a0

Add some stack slots to shuffle in the growing stack test case

6a7d2ce

Fix Equals signature on test structs

bb28b72

Remodel the shuffling with calling convention transfer to recognize t…

dbb5338

…he key points first, which simplifies code and solves some corner cases e.g. where we can't assume struct stack size by checking the size + offset of the last field

Use helper functions in EmitComputedInstantiatingMethodStub

68e0c36

Implement stack growing in shuffling thunk

015aed0

Use signed immediate in EmitSubImm to be consistent with EmitAddImm

3dcc74c

Use ABI register names in logs

afdec48

Remove LoadRegPair because it's not used

84bffa4

Add logging for slli and lui

de61b96

dotnet-issue-labeler bot added the area-VM-coreclr label Sep 3, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2024

clamp03 assigned tomeksowi Sep 3, 2024

clamp03 added the arch-riscv Related to the RISC-V architecture label Sep 3, 2024

Merge branch 'main' into fp-structs-shuffling-thunks

1c7b0b1

Fix release build

7f81c07

tomeksowi added 3 commits September 10, 2024 15:33

Fixes for static delegates from member methods

4b1b31a

Fix log and comment

2edf53d

Remove EmitJumpAndLinkRegister because it's no longer used

74dcd7c

tomeksowi marked this pull request as ready for review September 10, 2024 13:50

tomeksowi requested a review from jkotas September 10, 2024 13:55

build-analysis bot mentioned this pull request Sep 11, 2024

SIGKILL (OOM?) while running LibraryImportGenerator.Tests w/o actionable log messages or artifacts dotnet/dnceng#2496

Open

3 tasks

Use TransferredField.reg in delowering (cosmetic fix to restart CI)

c5f72c6

jkotas reviewed Sep 12, 2024

View reviewed changes

src/coreclr/vm/comdelegate.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/riscv64/stubs.cpp Show resolved Hide resolved

tomeksowi added 3 commits September 16, 2024 11:36

Merge branch 'main' into fp-structs-shuffling-thunks

5ed7466

New stub type for delegate shuffle thunk so it doesn't go in multidel…

3bbc188

…egate code paths

Make Test_ShufflingThunk_MemberGrowsStack_RiscV harder by returning v…

268a28b

…ia buffer

yurai007 reviewed Sep 17, 2024

View reviewed changes

src/coreclr/vm/riscv64/stubs.cpp Show resolved Hide resolved

src/coreclr/vm/riscv64/stubs.cpp Show resolved Hide resolved

src/coreclr/vm/riscv64/stubs.cpp Show resolved Hide resolved

yurai007 reviewed Sep 17, 2024

View reviewed changes

src/coreclr/vm/riscv64/stubs.cpp Show resolved Hide resolved

src/coreclr/vm/riscv64/stubs.cpp Show resolved Hide resolved

tomeksowi added 3 commits September 18, 2024 10:10

Explain lowering

ccd4aae

Fold 12-bit sign extension branch in EmitMovConstant

1c18c46

Harden Test_ShufflingThunk_PackedEmptyUintEmptyFloat_PackedEmptyDoubl…

6c7e29f

…e to cover interleaving FP and int arguments

tomeksowi requested a review from yurai007 September 18, 2024 14:49

yurai007 approved these changes Sep 19, 2024

View reviewed changes

tomeksowi requested a review from jkotas September 19, 2024 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

tomeksowi commented Sep 3, 2024

risc-vv commented Sep 9, 2024 •

edited

Loading

risc-vv commented Sep 10, 2024 •

edited

Loading

risc-vv commented Sep 10, 2024 •

edited

Loading

risc-vv commented Sep 10, 2024 •

edited

Loading

am11 commented Sep 10, 2024

tomeksowi commented Sep 10, 2024 •

edited

Loading

risc-vv commented Sep 11, 2024 •

edited

Loading

risc-vv commented Sep 16, 2024 •

edited

Loading

risc-vv commented Sep 18, 2024 •

edited

Loading

yurai007 left a comment

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

Are you sure you want to change the base?

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

Conversation

tomeksowi commented Sep 3, 2024

risc-vv commented Sep 9, 2024 • edited Loading

risc-vv commented Sep 10, 2024 • edited Loading

risc-vv commented Sep 10, 2024 • edited Loading

risc-vv commented Sep 10, 2024 • edited Loading

am11 commented Sep 10, 2024

tomeksowi commented Sep 10, 2024 • edited Loading

risc-vv commented Sep 11, 2024 • edited Loading

risc-vv commented Sep 16, 2024 • edited Loading

risc-vv commented Sep 18, 2024 • edited Loading

yurai007 left a comment

Choose a reason for hiding this comment

risc-vv commented Sep 9, 2024 •

edited

Loading

risc-vv commented Sep 10, 2024 •

edited

Loading

risc-vv commented Sep 10, 2024 •

edited

Loading

risc-vv commented Sep 10, 2024 •

edited

Loading

tomeksowi commented Sep 10, 2024 •

edited

Loading

risc-vv commented Sep 11, 2024 •

edited

Loading

risc-vv commented Sep 16, 2024 •

edited

Loading

risc-vv commented Sep 18, 2024 •

edited

Loading