[release/9.0] Set GC metrics to zero prior to first GC #107004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
tarekgh
approved these changes
Aug 27, 2024
artl93
approved these changes
Aug 27, 2024
|
M2 approved |
This was referenced Aug 27, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #106734 to release/9.0
/cc @noahfalk
Customer Impact
The new runtime metrics we added in 9.0 were originally implemented to not provide some GC metrics before the first GC occured. This behavior differed from what we had talked about in design discussion - that the metrics should be reported with a zero value before first GC. This PR brings the implementation back into alignment with the intended design.
Regression
Testing
This was verified both with manual testing and with updates to unit tests. Previously the unit tests were also validating the wrong behavior.
Risk
Low - this is a minor behavior change in a feature that released for the first time in preview 7.