Stop counting work items from ThreadPoolTypedWorkItemQueue for ThreadPool.CompletedWorkItemCount #106854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2024
kouvel
reviewed
Aug 23, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/ThreadPoolWorkQueue.cs
Show resolved
Hide resolved
kouvel
reviewed
Aug 23, 2024
src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Koundinya Veluri <kouvel@users.noreply.github.com>
This was referenced Aug 24, 2024
kouvel
approved these changes
Aug 26, 2024
3 tasks
This was referenced Aug 28, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…Pool.CompletedWorkItemCount (dotnet#106854) * Stop counting work items from ThreadPoolTypedWorkItemQueue as completed work items * Fix CompletedWorkItemCount * Update src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs Co-authored-by: Koundinya Veluri <kouvel@users.noreply.github.com> * Run CompletedWorkItemCountTest on Windows only --------- Co-authored-by: Eduardo Manuel Velarde Polar <evelardepola@microsoft.com> Co-authored-by: Koundinya Veluri <kouvel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These work items are used to parallelize the actual work items but they don't do any actual work. It's more precise to only count actual work items for ThreadPool.CompletedWorkItemCount.
Fixes #104284