Fix metrics size regression #106415
Merged
Fix metrics size regression #106415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding the startup init for runtime metrics recently I only used a dynamic check for the System.Diagnostics.Metrics.Meter.IsSupported AppContext flag. This had the right runtime behavior but couldn't be statically analyzed by ILLink so size was larger than necessary. Using a property the linker can be aware of should allow the code to be trimmed once again.
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti |
tarekgh
approved these changes
Aug 14, 2024
|
/ba-g the failed test is not related and is like the one already tracked by #106371 |
This was referenced Aug 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the startup init for runtime metrics recently I only used a dynamic check for the System.Diagnostics.Metrics.Meter.IsSupported AppContext flag. This had the right runtime behavior but couldn't be statically analyzed by ILLink so size was larger than necessary. Using a property the linker can be aware of should allow the code to be trimmed once again.