Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Select_LargeNumber_Succcess exclusive #105751

Merged
merged 3 commits into from
Aug 10, 2024
Merged

make Select_LargeNumber_Succcess exclusive #105751

merged 3 commits into from
Aug 10, 2024

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 31, 2024

contributes to #105688.
While this test handles fd exhaustion via try/catch it can impact other tests.

@wfurt wfurt added area-System.Net.Sockets test-bug Problem in test source code (most likely) labels Jul 31, 2024
@wfurt wfurt requested a review from a team July 31, 2024 12:07
@wfurt wfurt self-assigned this Jul 31, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.


[Collection(nameof(DisableParallelization))]
Copy link
Member

@liveans liveans Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is exhausting process-wise file descriptor limit, instead of disabling parallelization on this test, should we run this inside RemoteExecutor?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the limits are per process or per user. We may try both if this fails or we can disable it explicitly on tvOS and Catalyst

@wfurt
Copy link
Member Author

wfurt commented Aug 1, 2024

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wfurt
Copy link
Member Author

wfurt commented Aug 9, 2024

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Sockets test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants