Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Remove check for user agent when attaching debugger #105559

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 26, 2024

  • Remove check for user agent when attaching debugger
  • Attach debugger only when DebugLevel != 0
  • Don't zero debug level when there are no PDBs in config (embedded PDB can be used)

Fixes #104234

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 26, 2024
@maraf maraf added this to the 9.0.0 milestone Jul 26, 2024
@maraf maraf self-assigned this Jul 26, 2024
@maraf maraf requested a review from thaystg July 26, 2024 13:16
@thaystg
Copy link
Member

thaystg commented Jul 26, 2024

I don't like this check for PDB to decide the debug level because the customer should be able to use embedded pdbs?
Am I understanding the code wrongly?

@pavelsavara
Copy link
Member

I think that this change enables debugging on NodeJS, could you please test that it also works ?

@maraf
Copy link
Member Author

maraf commented Aug 9, 2024

could you please test that it also works ?

No, managed debugging doesn't work on NodeJS

@maraf maraf merged commit 7fa25e8 into dotnet:main Aug 9, 2024
34 of 37 checks passed
@maraf maraf deleted the BrowserDebuggerNoUserAgentCheck branch August 9, 2024 13:28
@lewing
Copy link
Member

lewing commented Aug 14, 2024

@maraf this appears to have turned off all optimizations on v8? dotnet/perf-autofiling-issues#39876

lewing added a commit that referenced this pull request Aug 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEBUGGING IS NOT ENABLED when trying to debug .NET 8 Blazor Web project simulating iOS device on edge
4 participants