Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete some dead code in finalizer loop #104287

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Delete some dead code in finalizer loop #104287

merged 1 commit into from
Jul 2, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jul 2, 2024

No description provided.

@jkotas jkotas requested a review from VSadov July 2, 2024 07:09
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member Author

jkotas commented Jul 2, 2024

Found while investigating #104218

@VSadov
Copy link
Member

VSadov commented Jul 2, 2024 •
edited
Loading

I saw the same redundancies in #103738

This change removes a few more though.

VSadov
VSadov approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkotas jkotas merged commit 7b1c0f3 into dotnet:main Jul 2, 2024
89 checks passed
@jkotas jkotas deleted the finalizer-dead-code branch July 2, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VSadov VSadov VSadov approved these changes

Assignees

@jkotas jkotas

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @VSadov