Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect class inited status more correctly in prestub/jitinterface #104253

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Detect class inited status more correctly in prestub/jitinterface #104253

merged 4 commits into from
Jul 3, 2024

Commits on Jul 1, 2024

  1. Fix dotnet#104247 by providing a new helper function which means what… 

    … the old IsClassInited helper meant
    @davidwrighton
    davidwrighton committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c9ca21e View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Tweak so that we compute the Init state when we ensure that the stati… 

    …c data is allocated

This allows the IsClassInitedOrPreinited function to be implemented with a single memory read in all repeated use cases
    @davidwrighton
    davidwrighton committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6dd8f82 View commit details
    Browse the repository at this point in the history

  2. Fix parentheses issue

    @davidwrighton
    davidwrighton committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4417cf4 View commit details
    Browse the repository at this point in the history

  3. - Fix issue where the gc statics field for strings isn't being checke… 

    …d correctly

- AND a very subtle race condition where we need to set the IsClassInited flag bit on dynamic statics BEFORE setting the MethodTable level one
    @davidwrighton
    davidwrighton committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    56092a1 View commit details
    Browse the repository at this point in the history