Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find all generic interface impls #103661

Closed
wants to merge 13 commits into from
Closed

Find all generic interface impls #103661

wants to merge 13 commits into from

Commits on Jun 11, 2024

  1. Use recursive-interface-aware types and methods in TypeMapInfo 

    - Rename InterfaceImplementor to RuntimeInterfaceImplementation
- Use 'interface implementation chains' everywhere rather than a single
  interface implementation
    @jtschuster
    jtschuster committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d6564fb View commit details
    Browse the repository at this point in the history

  2. Use RuntimeInterfaceImplementations in MethodBodyScanner and ICustomM… 

    …arshaler marking
    @jtschuster
    jtschuster committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8e94b0e View commit details
    Browse the repository at this point in the history

  3. Add remarks regarding checking for marked ifaceImpls with RuntimeInte… 

    …rfaceImpl
    @jtschuster
    jtschuster committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    cf304f2 View commit details
    Browse the repository at this point in the history

  4. Fix ApiCompat failures

    @jtschuster
    jtschuster committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    fcbfbb7 View commit details
    Browse the repository at this point in the history

  5. Fix visibility and sealed warnings

    @jtschuster
    jtschuster committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e5e0679 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Add DAM annotations for recursive interfaces

    @jtschuster
    jtschuster committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    451b677 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Add additional test cases and annotate reflection types with ifdefs

    @jtschuster
    jtschuster committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    1e1451a View commit details
    Browse the repository at this point in the history

  2. Use suppressions instead of annotating in System.Reflection.Context

    @jtschuster
    jtschuster committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ac5a42a View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Add test and fix for failure in System.Text.Json 

    When the base type has an interface and an unmarked derived type
overrides a method on that interface, we would mark the overriding
method without checking if the type is even marked. We will check if the
declaring type is marked before marking the override.
    @jtschuster
    jtschuster committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4e1f6f9 View commit details
    Browse the repository at this point in the history

  2. Check for implementor to be marked, not overridingMethod.DeclaringType

    @jtschuster
    jtschuster committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f8dad6b View commit details
    Browse the repository at this point in the history

  3. PR feedback: 

    - Make methods local methods with captured variables
- Inline local variables
- Only store interfaces in runtime interfaces dictionary if the type
  implements 1 or more interfaces
- Rename variables
    @jtschuster
    jtschuster committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2aca6c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Separate out generic DIM matching fix

    @jtschuster
    jtschuster committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    bb308c7 View commit details
    Browse the repository at this point in the history

  2. Revert "Separate out generic DIM matching fix" 

    This reverts commit bb308c7.
    @jtschuster
    jtschuster committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    fd1d44f View commit details
    Browse the repository at this point in the history