Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0-staging] Merge #78968 #103312

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[release/6.0-staging] Merge #78968 #103312

merged 1 commit into from
Jun 12, 2024

Conversation

amanasifkhalid
Copy link
Member

@amanasifkhalid amanasifkhalid commented Jun 11, 2024 •
edited
Loading

Follow-up to #103266 (comment). @jkoritzinsky PTAL, thanks!

Official build

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 11, 2024
@amanasifkhalid amanasifkhalid added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 11, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid marked this pull request as ready for review June 11, 2024 22:48
@amanasifkhalid
Copy link
Member Author

wasm test failures are #91987. Libraries test failures are #100558.

This was referenced Jun 12, 2024
Open
Open
jeffschwMSFT
jeffschwMSFT approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode.

cc @carlossanlop

@amanasifkhalid amanasifkhalid added the Servicing-approved Approved for servicing release label Jun 12, 2024
@amanasifkhalid amanasifkhalid merged commit 255d1c5 into dotnet:release/6.0-staging Jun 12, 2024
141 of 152 checks passed
@amanasifkhalid amanasifkhalid deleted the amanasifkhalid/merge-78968 branch June 12, 2024 14:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

Assignees

@amanasifkhalid amanasifkhalid

Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanasifkhalid @jkoritzinsky @jeffschwMSFT