Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonBacktracking Regex optimizations #102655

Merged
merged 63 commits into from
Jul 11, 2024
Merged

NonBacktracking Regex optimizations #102655

merged 63 commits into from
Jul 11, 2024

Commits on Jul 10, 2024

  1. Regex automata optimizations

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    34eba54 View commit details
    Browse the repository at this point in the history

  2. off by one err

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    49607f4 View commit details
    Browse the repository at this point in the history

  3. wip reversal optimizations

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5ac29f3 View commit details
    Browse the repository at this point in the history

  4. removing unnecessary overhead

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e440dec View commit details
    Browse the repository at this point in the history

  5. handle final position correctly

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    627fd90 View commit details
    Browse the repository at this point in the history

  6. edge case workarounds, tests should be ok again

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7ae6440 View commit details
    Browse the repository at this point in the history

  7. optimizing lookup initialization

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    383f3e5 View commit details
    Browse the repository at this point in the history

  8. more dfa overhead removed

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5a2636c View commit details
    Browse the repository at this point in the history

  9. removed potential rewrite

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    57e5b8d View commit details
    Browse the repository at this point in the history

  10. low memory variant

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4d275db View commit details
    Browse the repository at this point in the history

  11. some kind of compromise between speed and memory

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c35ed7e View commit details
    Browse the repository at this point in the history

  12. cheaper nullability checks

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    868e02d View commit details
    Browse the repository at this point in the history

  13. nullability encoding

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    14afd18 View commit details
    Browse the repository at this point in the history

  14. nullability cached as bytes

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5f5ab55 View commit details
    Browse the repository at this point in the history

  15. reverting some changes

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    dd121de View commit details
    Browse the repository at this point in the history

  16. testing nfa fallback

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    723c5b6 View commit details
    Browse the repository at this point in the history

  17. refactoring, work in progress

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    6bf4095 View commit details
    Browse the repository at this point in the history

  18. refactoring to struct interfaces

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b10e600 View commit details
    Browse the repository at this point in the history

  19. refactoring optimizations

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d68bd3c View commit details
    Browse the repository at this point in the history

  20. fallback mode and bugfix

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    153dfc3 View commit details
    Browse the repository at this point in the history

  21. reenable warnings

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4aebe3e View commit details
    Browse the repository at this point in the history

  22. anchor edge case

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1e6f55c View commit details
    Browse the repository at this point in the history

  23. anchor edge cases

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    c6ad3ac View commit details
    Browse the repository at this point in the history

  24. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @ieviev @stephentoub
    ieviev and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e10b43f View commit details
    Browse the repository at this point in the history

  25. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @ieviev @stephentoub
    ieviev and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f581755 View commit details
    Browse the repository at this point in the history

  26. rebased branch and some cleanup

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    01a9684 View commit details
    Browse the repository at this point in the history

  27. cleanup, removing unused features

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    341ce27 View commit details
    Browse the repository at this point in the history

  28. cleanup

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    1a28c69 View commit details
    Browse the repository at this point in the history

  29. timeout limit changes

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9bba84f View commit details
    Browse the repository at this point in the history

  30. lookup allocation threshold and timeout limits

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a957781 View commit details
    Browse the repository at this point in the history

  31. char mapping

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7e86855 View commit details
    Browse the repository at this point in the history

  32. empty array mapping

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    99b5717 View commit details
    Browse the repository at this point in the history

  33. adding timeout check to create-derivative

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    47c6b04 View commit details
    Browse the repository at this point in the history

  34. some cleanup

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    22d23fa View commit details
    Browse the repository at this point in the history

  35. comments and cleanup

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    761f897 View commit details
    Browse the repository at this point in the history

  36. cleanup and comments

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    53924eb View commit details
    Browse the repository at this point in the history

  37. reflecting new limits in tests

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e66d3d3 View commit details
    Browse the repository at this point in the history

  38. rerunning tests

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    65c0b8b View commit details
    Browse the repository at this point in the history

  39. retesting DFA timeout

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    de085b4 View commit details
    Browse the repository at this point in the history

  40. more precise regex memory limit for DFA mode

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5ef3b32 View commit details
    Browse the repository at this point in the history

  41. reverting change

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    281446f View commit details
    Browse the repository at this point in the history

  42. reverting reversal refactor

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8f78046 View commit details
    Browse the repository at this point in the history

  43. Apply suggestions from code review 

    Co-authored-by: Dan Moseley <danmose@microsoft.com>
    @ieviev @danmoseley @stephentoub
    2 people authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    7157520 View commit details
    Browse the repository at this point in the history

  44. variable naming

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    931552d View commit details
    Browse the repository at this point in the history

  45. test for over 255 minterms

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cc493f1 View commit details
    Browse the repository at this point in the history

  46. adding net directive around test

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    a0d2390 View commit details
    Browse the repository at this point in the history

  47. all engines in minterms test

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0691c58 View commit details
    Browse the repository at this point in the history

  48. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @ieviev @stephentoub
    ieviev and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8ceb207 View commit details
    Browse the repository at this point in the history

  49. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @ieviev @stephentoub
    ieviev and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    379519b View commit details
    Browse the repository at this point in the history

  50. simplifying code

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    57c8f6d View commit details
    Browse the repository at this point in the history

  51. state flag values down

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2e57d42 View commit details
    Browse the repository at this point in the history

  52. mintermclassifier changes

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    60b1352 View commit details
    Browse the repository at this point in the history

  53. reversal

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2900aad View commit details
    Browse the repository at this point in the history

  54. getstateflags

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    764ded8 View commit details
    Browse the repository at this point in the history

  55. formatting

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    81d0dca View commit details
    Browse the repository at this point in the history

  56. removing unused interface

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    38f28b9 View commit details
    Browse the repository at this point in the history

  57. local function typo

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    cce1188 View commit details
    Browse the repository at this point in the history

  58. temporarily removing minterms test

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8b946da View commit details
    Browse the repository at this point in the history

  59. re-adding minterms test

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    d3430b3 View commit details
    Browse the repository at this point in the history

  60. reenabling test for all engines

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    388c256 View commit details
    Browse the repository at this point in the history

  61. test bugfix

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2704641 View commit details
    Browse the repository at this point in the history

  62. expected matches change

    @ieviev @stephentoub
    ieviev authored and stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0abaabe View commit details
    Browse the repository at this point in the history

  63. Review and clean up some code 

    Simplification, style consistency, dead code deletion, some bounds-check removal, etc.
    @stephentoub
    stephentoub committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0a0f409 View commit details
    Browse the repository at this point in the history