Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the discrepancy between applicationName between normal app launch and HostFactoryResolver launch #102152

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

GMPrakhar
Copy link
Contributor

Fixed the discrepancy between applicationName between normal app launch and HostFactoryResolver launch

#96596

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 13, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

@steveharter steveharter self-requested a review May 15, 2024 20:04
@buyaa-n buyaa-n self-assigned this Jun 12, 2024
@steveharter
Copy link
Member

For reference, see

applicationName = Assembly.GetEntryAssembly()?.GetName().Name;

and
args = args.Any(arg => IsApplicationNameArg(arg)) || assembly.FullName is null
? args
: args.Concat(new[] { "--applicationName", assembly.FullName }).ToArray();

@steveharter
Copy link
Member

We'll need to monitor downstream users - ASP.NET \ EF for breaks here.

@kasperk81
Copy link
Contributor

this is blocking code flow #103553

@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Hosting community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants