Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX10.1 API introduction in JIT #101938

Merged
merged 22 commits into from
Jun 9, 2024

Conversation

khushal1996
Copy link
Contributor

@khushal1996 khushal1996 commented May 6, 2024

This PR tracks addition of AVX10.1 APIs in libraries along with relevant template tests and intrinsics in JIT. It also captures usage of the new intrinsics in JIT during lowering.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels May 6, 2024
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 6, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@tannergooding
Copy link
Member

CC. @dotnet/jit-contrib PR from Intel is ready for review and needs secondary sign-off.

I've given this a decently thorough review already and plan on giving it one more pass before sign-off, but it could definitely do with another pair of eyes.

@JulieLeeMSFT
Copy link
Member

@EgorBo please review the PR for AVX10.1.

@JulieLeeMSFT JulieLeeMSFT requested a review from EgorBo June 5, 2024 23:28

retNode =
gtNewSimdHWIntrinsicNode(TYP_SIMD16, op1, op2, op3, NI_FMA_MultiplyAddScalar, callJitType, 16);
GenTree* op3 = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, impPopStack().val, callJitType, 16);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we remove impImplicitR4orR8Cast from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a merge error when rebasing. cleared it up to what it was.

@EgorBo
Copy link
Member

EgorBo commented Jun 6, 2024

@MihuBot

Copy link
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the RyuJIT side is ok with the Tanner's comments. Do we want to run some ISA outerloops?

@EgorBo
Copy link
Member

EgorBo commented Jun 6, 2024

Any idea why this PR causes big diffs on an Intel cpu (must be some Skylake/Cascade Lake cpu on Azure): MihuBot/runtime-utils#403 ? I presume it's supposed to be no-op

@DeepakRajendrakumaran
Copy link
Contributor

Any idea why this PR causes big diffs on an Intel cpu (must be some Skylake/Cascade Lake cpu on Azure): MihuBot/runtime-utils#403 ? I presume it's supposed to be no-op

Something is off here. We are not inlining the Vector512 method in some of these and resorting to software fallback

@DeepakRajendrakumaran
Copy link
Contributor

Any idea why this PR causes big diffs on an Intel cpu (must be some Skylake/Cascade Lake cpu on Azure): MihuBot/runtime-utils#403 ? I presume it's supposed to be no-op

Something is off here. We are not inlining the Vector512 method in some of these and resorting to software fallback

There is a bug in there re ordering of flags being set. It got introduced when we added _EVEX flag. Will add a fix today

…rmatting adn resolve errors introduced when merging with main
@khushal1996
Copy link
Contributor Author

khushal1996 commented Jun 7, 2024

Any idea why this PR causes big diffs on an Intel cpu (must be some Skylake/Cascade Lake cpu on Azure): MihuBot/runtime-utils#403 ? I presume it's supposed to be no-op

@EgorBo I have pushed a fix and here are the diffs

Ice lake
image

Cascade Lake
image

@tannergooding tannergooding merged commit b5948bf into dotnet:main Jun 9, 2024
169 of 172 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants