Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GCLogParser to NetCoreAppToolCurrent #101089

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Upgrade GCLogParser to NetCoreAppToolCurrent #101089

merged 3 commits into from
Jun 3, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 15, 2024

net472 -> net9

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2024
@am11 am11 added area-GC-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 15, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@am11 am11 mentioned this pull request Apr 16, 2024
Merged
@mangod9
Copy link
Member

mangod9 commented May 13, 2024

Hi @am11, Was the motivation to add some functionality to this tool after moving to latest runtime?

@am11
Copy link
Member Author

am11 commented May 13, 2024

Hi @am11, Was the motivation to add some functionality to this tool after moving to latest runtime?

It was motivated by #101084, which in turn was motivated by #101038 to cleanup unnecessary arch-specific builds (in this case <PlatformTarget>x64</PlatformTarget> etc.).

@mangod9
Copy link
Member

mangod9 commented May 13, 2024

ok sounds good.

This was referenced May 13, 2024
Closed
Open
Open
@jkotas jkotas closed this Jun 3, 2024
@jkotas jkotas reopened this Jun 3, 2024
@build-analysis build-analysis bot mentioned this pull request Jun 3, 2024
Closed
@jkotas jkotas merged commit 4c27290 into dotnet:main Jun 3, 2024
87 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@mangod9 mangod9 mangod9 approved these changes

Assignees
No one assigned
Labels
area-GC-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@am11 @mangod9 @akoeplinger @jkotas