Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Wrong architecture libc++ bundled with wasm cross-compilers on linux-arm64 #93015

Closed
directhex opened this issue Oct 4, 2023 · 3 comments · Fixed by #93027
Closed

[release/8.0] Wrong architecture libc++ bundled with wasm cross-compilers on linux-arm64 #93015

directhex opened this issue Oct 4, 2023 · 3 comments · Fixed by #93027
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Milestone
8.0.0

Comments

@directhex
Copy link
Member

Description

x64 libc++ is getting bundled. Investigating why.

Reproduction Steps

Expected behavior

Actual behavior

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 4, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 4, 2023
@directhex directhex added this to the 8.0.0 milestone Oct 4, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 4, 2023
@directhex
Copy link
Member Author

OK, this is specifically an issue for Wasm, the linux-arm64->android-* has the correct arch libc++

@directhex directhex mentioned this issue Oct 4, 2023
Merged
2 tasks
@directhex
Copy link
Member Author

Not specific to release/8.0, bad in main

@directhex
Copy link
Member Author

directhex commented Oct 4, 2023 •
edited
Loading

The combination of https://github.com/dotnet/runtime/blame/main/src/mono/mono.proj#L258 and https://github.com/dotnet/runtime/blame/main/src/mono/mono.proj#L991 is clearly always wrong for WASM, and whoever wrote these conditionals is an idiot.

Working on a fix ASAP.

directhex added a commit to directhex/runtime that referenced this issue Oct 4, 2023
@directhex
Try to resolve x64 libc++ being included with linux-arm64 to
8773505 
browser-wasm cross-compilers, due to incorrect assumption that
the build architecture should be used for wasm cases.
Closes: dotnet#93015
@directhex directhex mentioned this issue Oct 4, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 4, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 5, 2023
github-actions bot pushed a commit that referenced this issue Oct 5, 2023
@directhex
Try to resolve x64 libc++ being included with linux-arm64 to browser-…
ede6151 
…wasm cross-compilers, due to incorrect assumption that the build architecture should be used for wasm cases. Closes: #93015
carlossanlop pushed a commit that referenced this issue Oct 6, 2023
@github-actions @directhex
[release/8.0] Resolve x64 libc++ being included with linux-arm64 to b…
b17a34c 
…rowser-wasm cross-compiler (#93070)

* Try to resolve x64 libc++ being included with linux-arm64 to browser-wasm cross-compilers, due to incorrect assumption that the build architecture should be used for wasm cases. Closes: #93015

* Still bad. Remove a condition.

---------

Co-authored-by: Jo Shields <joshield@microsoft.com>
Co-authored-by: Jo Shields <directhex@apebox.org>
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Try to resolve x64 libc++ being included with linux-arm64 directhex/runtime
1 participant
@directhex