jitformat failing on linux x64 #84780

AndyAyersMS · 2023-04-13T15:03:27Z

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=237232
Build error leg or test failing: Build / Formatting linux x64 / Run jitformat.py
Pull request: #84741

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "syntax error near unexpected token",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Report

Build	Definition	Step Name	Console log	Pull Request
238577	dotnet/runtime	Run jitformat.py	Log	#84605
238556	dotnet/runtime	Run jitformat.py	Log
238510	dotnet/runtime	Run jitformat.py	Log	#84716
238380	dotnet/runtime	Run jitformat.py	Log
237357	dotnet/runtime	Run jitformat.py	Log	#84605
238326	dotnet/runtime	Run jitformat.py	Log	#84734
238210	dotnet/runtime	Run jitformat.py	Log	#84772
238204	dotnet/runtime	Run jitformat.py	Log	#84772
237232	dotnet/runtime	Run jitformat.py	Log	#84741
238043	dotnet/runtime	Run jitformat.py	Log	#84661
237909	dotnet/runtime	Run jitformat.py	Log	#84765
237995	dotnet/runtime	Run jitformat.py	Log	#84772
237866	dotnet/runtime	Run jitformat.py	Log	#84661
237804	dotnet/runtime	Run jitformat.py	Log	#84748
237792	dotnet/runtime	Run jitformat.py	Log
237775	dotnet/runtime	Run jitformat.py	Log	#84275
237744	dotnet/runtime	Run jitformat.py	Log
237666	dotnet/runtime	Run jitformat.py	Log	#84731
237598	dotnet/runtime	Run jitformat.py	Log	#84275
237469	dotnet/runtime	Run jitformat.py	Log	#84748
237373	dotnet/runtime	Run jitformat.py	Log	#84661
237337	dotnet/runtime	Run jitformat.py	Log	#84716
237422	dotnet/runtime	Run jitformat.py	Log
237416	dotnet/runtime	Run jitformat.py	Log	#83151
237107	dotnet/runtime	Run jitformat.py	Log	#84275
237112	dotnet/runtime	Run jitformat.py	Log	#84275
237002	dotnet/runtime	Run jitformat.py	Log	#84731

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
2	27	27

ghost · 2023-04-13T15:03:42Z

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=237232
Build error leg or test failing: Build / Formatting linux x64 / Run jitformat.py
Pull request: #84741

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "syntax error near unexpected token",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Author:	AndyAyersMS
Assignees:	-
Labels:	`area-Infrastructure-libraries`, `blocking-clean-ci`, `Known Build Error`
Milestone:	-

kunalspathak · 2023-04-13T18:52:43Z

It seems that we are not able to download the clang tools although the code in the script that verifies the url seems correct. I have sent out dotnet/jitutils#368 to log the download url links.

Edit: I verified it locally and it works.

BruceForstall · 2023-04-13T23:34:39Z

Looks like making available the clang-format/clang-tidy wasn't good enough. Now on linux-x64 we have:

Can't find compile_commands.json file. Running configure.
Running: /__w/1/s/src/coreclr/build-runtime.sh x64 Checked configureonly -cmakeargs -DCMAKE_EXPORT_COMPILE_COMMANDS=1
Unhandled exception. System.IO.FileNotFoundException: Could not find file '/__w/1/s/artifacts/obj/coreclr/linux.x64.Checked/compile_commands.json'.
File name: '/__w/1/s/artifacts/obj/coreclr/linux.x64.Checked/compile_commands.json'
   at System.IO.File.Move(String sourceFileName, String destFileName, Boolean overwrite)
   at ManagedCodeGen.jitformat.Main(String[] args) in /tmp/tmpe86afm5e/jitutils/src/jit-format/jit-format.cs:line 502

So maybe the "configureonly" build is failing?

@jkoritzinsky ideas?

BruceForstall · 2023-04-13T23:36:04Z

Test PR:

https://dev.azure.com/dnceng-public/public/_build/results?buildId=238765&view=logs&jobId=32acbff2-0723-5398-e8b4-f0caab88bd5c&j=32acbff2-0723-5398-e8b4-f0caab88bd5c&t=336ebb8d-7afa-5e0a-21cd-ad905aa5f221

ghost · 2023-04-13T23:36:46Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=237232
Build error leg or test failing: Build / Formatting linux x64 / Run jitformat.py
Pull request: #84741

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "syntax error near unexpected token",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Report

Build	Definition	Step Name	Console log	Pull Request
237357	dotnet/runtime	Run jitformat.py	Log	#84605
237232	dotnet/runtime	Run jitformat.py	Log	#84741
238043	dotnet/runtime	Run jitformat.py	Log	#84661
237909	dotnet/runtime	Run jitformat.py	Log	#84765
237995	dotnet/runtime	Run jitformat.py	Log	#84772
237866	dotnet/runtime	Run jitformat.py	Log	#84661
237804	dotnet/runtime	Run jitformat.py	Log	#84748
237775	dotnet/runtime	Run jitformat.py	Log	#84275
237744	dotnet/runtime	Run jitformat.py	Log
237666	dotnet/runtime	Run jitformat.py	Log	#84731
237469	dotnet/runtime	Run jitformat.py	Log	#84748
237373	dotnet/runtime	Run jitformat.py	Log	#84661
237337	dotnet/runtime	Run jitformat.py	Log	#84716
237416	dotnet/runtime	Run jitformat.py	Log	#83151
237107	dotnet/runtime	Run jitformat.py	Log	#84275
237112	dotnet/runtime	Run jitformat.py	Log	#84275
237002	dotnet/runtime	Run jitformat.py	Log	#84731

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
17	17	17

Author:	AndyAyersMS
Assignees:	BruceForstall
Labels:	`area-Infrastructure-coreclr`, `blocking-clean-ci`, `Known Build Error`
Milestone:	8.0.0

BruceForstall · 2023-04-13T23:39:15Z

Looks like the Docker container is build.ubuntu.1804.amd64.open

BruceForstall · 2023-04-14T06:36:57Z

This looks like the same issue as #84822: the Docker container used to build changed from centos to mariner

@sbomer @jkoritzinsky @steveisok PTAL

BruceForstall · 2023-04-14T06:44:48Z

This is due to #84148

sbomer · 2023-04-14T19:01:30Z

Guessing we need to pass the -cross argument to the build-runtime.sh script. I'll try to repro this.

@BruceForstall

Fixes dotnet/runtime#84780. Tested by hooking up the changes locally with runtime's `jitformat.py` and running `python3 ./src/coreclr/scripts/jitformat.py -c /runtime/src/coreclr -o linux -a x64` in our mariner build container. This might break scenarios where jitutils are used outside of ci on a non-mariner build image. Per discussion with @BruceForstall let's make a quick fix to unblock ci, and if this is problematic we could for example add an extra argument that controls whether the `-cross` argument is passed to the runtime build. For context, the `-cross` argument is necessary after dotnet/runtime#84148 because our linux build images have change from centos 7 to CBL-mariner, and the linux builds are now cross-builds that use a rootfs (even x64 and x64-musl).

BruceForstall · 2023-04-14T21:24:19Z

I verified the fix with test PR #84862

AndyAyersMS added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 13, 2023

dotnet-issue-labeler bot added the area-Infrastructure-libraries label Apr 13, 2023

ghost added the untriaged New issue has not been triaged by the area owner label Apr 13, 2023

AndyAyersMS mentioned this issue Apr 13, 2023

JIT: extend initial profile repair to more cases #84741

Merged

SingleAccretion mentioned this issue Apr 13, 2023

Always set GTF_GLOB_REF on block indirs #84731

Merged

EgorBo mentioned this issue Apr 13, 2023

Don't reorder blocks too early in helper call expansion #84765

Merged

BruceForstall self-assigned this Apr 13, 2023

kunalspathak mentioned this issue Apr 13, 2023

Print the clang tools download url dotnet/jitutils#368

Closed

BruceForstall modified the milestones: Future, 8.0.0 Apr 13, 2023

ghost removed the untriaged New issue has not been triaged by the area owner label Apr 13, 2023

BruceForstall mentioned this issue Apr 13, 2023

Fix clang tool downloads #84799

Merged

ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 13, 2023

BruceForstall closed this as completed in #84799 Apr 13, 2023

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 13, 2023

BruceForstall reopened this Apr 13, 2023

carlossanlop added area-Infrastructure-coreclr and removed area-Infrastructure-libraries labels Apr 13, 2023

markples mentioned this issue Apr 14, 2023

Fix type initialization ordering under R2R #84275

Merged

BruceForstall assigned sbomer and unassigned BruceForstall Apr 14, 2023

sbomer mentioned this issue Apr 14, 2023

Pass "-cross" arg on linux builds dotnet/jitutils#369

Merged

BruceForstall closed this as completed in dotnet/jitutils#369 Apr 14, 2023

ghost locked as resolved and limited conversation to collaborators May 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jitformat failing on linux x64 #84780

jitformat failing on linux x64 #84780

AndyAyersMS commented Apr 13, 2023 •

edited by build-analysis bot

Loading

ghost commented Apr 13, 2023

Build Information

Error Message

kunalspathak commented Apr 13, 2023 •

edited

Loading

BruceForstall commented Apr 13, 2023

BruceForstall commented Apr 13, 2023

ghost commented Apr 13, 2023

Build Information

Error Message

Report

Summary

BruceForstall commented Apr 13, 2023

BruceForstall commented Apr 14, 2023

BruceForstall commented Apr 14, 2023

sbomer commented Apr 14, 2023

BruceForstall commented Apr 14, 2023

jitformat failing on linux x64 #84780

jitformat failing on linux x64 #84780

Comments

AndyAyersMS commented Apr 13, 2023 • edited by build-analysis bot Loading

Build Information

Error Message

Report

Summary

ghost commented Apr 13, 2023

Build Information

Error Message

kunalspathak commented Apr 13, 2023 • edited Loading

BruceForstall commented Apr 13, 2023

BruceForstall commented Apr 13, 2023

ghost commented Apr 13, 2023

Build Information

Error Message

Report

Summary

BruceForstall commented Apr 13, 2023

BruceForstall commented Apr 14, 2023

BruceForstall commented Apr 14, 2023

sbomer commented Apr 14, 2023

BruceForstall commented Apr 14, 2023

AndyAyersMS commented Apr 13, 2023 •

edited by build-analysis bot

Loading

kunalspathak commented Apr 13, 2023 •

edited

Loading