Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store unhandled exception info on stack in Native AOT #84636

Closed
agocke opened this issue Apr 11, 2023 · 2 comments · Fixed by #84871
Closed

Store unhandled exception info on stack in Native AOT #84636

agocke opened this issue Apr 11, 2023 · 2 comments · Fixed by #84871
Labels
area-NativeAOT-coreclr
Milestone
8.0.0

Comments

@agocke
Copy link
Member

agocke commented Apr 11, 2023

The basic problem here is tools scanning crash dumps from Native AOT and needing information about unhandled exceptions that caused the crash. Because Native AOT has its own exception handling mechanism, most tools will not automatically know what to look for.

One solution to this is to store additional info directly in the stack, which almost all crash dumps will preserve for analysis.
@agocke agocke added this to the 8.0.0 milestone Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

The basic problem here is tools scanning crash dumps from Native AOT and needing information about unhandled exceptions that caused the crash. Because Native AOT has its own exception handling mechanism, most tools will not automatically know what to look for.

One solution to this is to store additional info directly in the stack, which almost all crash dumps will preserve for analysis.

Author: agocke
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: 8.0.0

@jkotas
Copy link
Member

jkotas commented Apr 12, 2023

There is a bunch of left-over UWP code under FEATURE_DUMP_DEBUGGING ifdefs. It is not relevant anymore - it assumes aux minidump provider that we do not want to have for native AOT. This left-over code should be deleted as part of this change.

agocke added a commit to agocke/runtime that referenced this issue Apr 15, 2023
@agocke
Attempt to fix dotnet#84636
dda1f63
@jkotas jkotas mentioned this issue Apr 25, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 25, 2023
agocke added a commit that referenced this issue Apr 27, 2023
@agocke
Store unhandled exception info on stack in Native AOT (#84871)
5d65dd6 
Allocates a span on the stack to hold the ToString of the exception, as well as a CrashRecord which contains a unique cookie that can be used to find the exception info.

Fixes #84636
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-NativeAOT-coreclr
Projects
AppModel
Archived in project
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Store unhandled exception info on stack in Native AOT agocke/runtime
2 participants
@agocke @jkotas