Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up on mono toolchain workload PR feedback #73758

Closed
akoeplinger opened this issue Aug 11, 2022 · 0 comments · Fixed by #76942
Closed

Follow up on mono toolchain workload PR feedback #73758

akoeplinger opened this issue Aug 11, 2022 · 0 comments · Fixed by #76942
Labels
area-Build-mono
Milestone
8.0.0

Comments

@akoeplinger
Copy link
Member

Looks like we missed some feedback from Viktor on this PR: #51327 (review)

We should address it.
@akoeplinger akoeplinger added this to the 8.0.0 milestone Aug 11, 2022
@carlossanlop carlossanlop mentioned this issue Oct 11, 2022
Closed
radical added a commit to radical/runtime that referenced this issue Oct 12, 2022
@radical
Misc fixes based on review feedback
6cc8e6f 
Fixes dotnet#73758 .
@radical radical mentioned this issue Oct 12, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 12, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Oct 21, 2022
radical added a commit that referenced this issue Oct 21, 2022
@radical
[wasm] Misc fixes (#76942)
3cb7f5a 
* [wasm] Fix Wasm.Build.Tests with stable 7.0.0

Set the manifest package version to use (`7.0.0` instead of `7.0.0-ci`)
early.

Fixes #76908 .

* Misc fixes based on review feedback

Fixes #73758 .

* Update WorkloadBuildTasksDir to remove 'publish' in the path

* workloads-testing.targets: ignore symbols.nupkgs when looking for runtime packs

* Fix WBT to have the correct version for WORKLOAD_PACKS_VER

* [wasm] Emit an error if PackageVersionForWorkloadManifests property is not set

* workloads-testing: Get the PackageVersion at build time

.. because it is not set at evaluation time. So, get it in a target, and
move the WorkloadIds to a target too.

* Ensure the version is set before generating the runscript for WBT
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] Misc fixes radical/runtime
1 participant
@akoeplinger