Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossgen2 determinism fails with tiered pgo #51898

Closed
AndyAyersMS opened this issue Apr 26, 2021 · 0 comments · Fixed by #51903
Closed

crossgen2 determinism fails with tiered pgo #51898

AndyAyersMS opened this issue Apr 26, 2021 · 0 comments · Fixed by #51903
Assignees
@AndyAyersMS
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
6.0.0

Comments

@AndyAyersMS
Copy link
Member

Failed in weekend testing:

        1 / 1 (100%, 1 failed): failed in 21301 msecs, exit code -1073740286 = 0xC0000602, expected 0: corerun.exe C:\h\w\B106099F\p\crossgen2\crossgen2.dll @C:\h\w\B106099F\w\A02C0898\e\readytorun\coreroot_determinism\coreroot_determinism\seed1\CPAOT-ret.out\System.Private.CoreLib.dll.rsp
        !! Assert failure(PID 11800 [0x00002e18], Thread: 11760 [0x2df0]): Assertion failed 'OperIs(GT_LCL_VAR, GT_LCL_FLD, GT_PHI_ARG, GT_STORE_LCL_VAR, GT_STORE_LCL_FLD, GT_LCL_VAR_ADDR, GT_LCL_FLD_ADDR)' in 'ILCompiler.Compilation:IsEffectivelySealed(Internal.TypeSystem.MethodDesc):bool:this' during 'Morph - Global' (IL size 13)
        !!     File: D:\workspace\_work\1\s\src\coreclr\jit\gtstructs.h Line: 63
        !!     Image: C:\h\w\B106099F\p\corerun.exe

Looks like the problem is that the "exit sequence" after a tail call has a more complex structure than #50806 is prepared to sanction. In particular there are assignments with casts, and a nop.

I have a fix in progress.
@AndyAyersMS AndyAyersMS self-assigned this Apr 26, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Apr 26, 2021
@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label Apr 26, 2021
@AndyAyersMS AndyAyersMS added this to the 6.0.0 milestone Apr 26, 2021
AndyAyersMS added a commit to AndyAyersMS/runtime that referenced this issue Apr 27, 2021
@AndyAyersMS
JIT: generalize checking for valid IR after a tail call
b40321e 
Allow NOPs and assignments with non-overflowing casts, in addition
to the assignments we already allowed.

Closes dotnet#51898.
@AndyAyersMS AndyAyersMS mentioned this issue Apr 27, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 27, 2021
@AndyAyersMS AndyAyersMS mentioned this issue Apr 27, 2021
Merged
AndyAyersMS added a commit that referenced this issue Apr 27, 2021
@AndyAyersMS
JIT: generalize checking for valid IR after a tail call (#51903)
2d71fe2 
Allow NOPs and assignments with non-overflowing casts, in addition
to the assignments we already allowed.

Closes #51898.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 27, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
.NET Core CodeGen
Archived in project
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

JIT: generalize checking for valid IR after a tail call AndyAyersMS/runtime
1 participant
@AndyAyersMS