Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Reflection issues which would be breaking changes if fixed #40737

Closed
2 tasks done
GrabYourPitchforks opened this issue Aug 12, 2020 · 3 comments
Closed
2 tasks done
Labels
area-System.Reflection discussion needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Milestone

Comments

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Aug 12, 2020

Spoke with @steveharter yesterday and realized that there's a category of reflection issues which are truly legitimate bugs but which could be considered breaking changes if they were addressed. This meta-issue is an effort to aggregate these individual issues as we encounter them.

We need to determine the correct course of action for this category of issue. Should we fix them? What's the appropriate balance between allowing 20-year-old code to work without changes vs. forcing all consumers of reflection to read the docs errata?

@GrabYourPitchforks GrabYourPitchforks added this to the 6.0.0 milestone Aug 12, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 12, 2020
@GrabYourPitchforks
Copy link
Member Author

I've tentatively marked this 6.0 so that we can make a decision soon as to how we want to address this category of issue.

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Aug 31, 2020
@krwq
Copy link
Member

krwq commented Jul 20, 2021

@GrabYourPitchforks @steveharter have there been any conclusions there? In the meantime I'm moving this to 7.0. For some of these issues like the second one i.e. we could consider adding new overload perhaps (with extra bool telling to show all properties including the hidden ones)

@steveharter
Copy link
Member

IMO if a given API is broken (e.g. Type.IsPublic is wrong for by-ref types) we should fix it even though technically it would be breaking change. One consideration on this is whether there is an existing workaround for the incorrect behavior (i.e. check if by-ref type and check for Public some other way) and whether the workaround continue to work as-is even though the underlying issue was fixed -- if so, then IMO it is much more palatable to do these breaking changes.

@ghost ghost added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jan 12, 2022
@buyaa-n buyaa-n closed this as completed Jul 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection discussion needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Projects
No open projects
Development

No branches or pull requests

6 participants