Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type.IsPublic returns wrong answer for pointer and byref types #12355

Closed
Tracked by #44655
GrabYourPitchforks opened this issue Mar 27, 2019 · 6 comments · Fixed by #65156
Closed
Tracked by #44655

Type.IsPublic returns wrong answer for pointer and byref types #12355

GrabYourPitchforks opened this issue Mar 27, 2019 · 6 comments · Fixed by #65156

Comments

@GrabYourPitchforks
Copy link
Member

Even though int is public, int* and int& aren't. Sample code below.

Console.WriteLine(typeof(int).MakePointerType().IsPublic); // prints 'False', expected 'True'
Console.WriteLine(typeof(int).MakeByRefType().IsPublic); // prints 'False', expected 'True'

Perhaps an oversight when copying the elemental Type's visibility attributes into the pointer / byref Type we manfacture behind the scenes?

(Found by @stephentoub)

@steveharter
Copy link
Member

Moving to future; not in scope for 3.0.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 26, 2020
@GrabYourPitchforks GrabYourPitchforks modified the milestones: Future, 5.0 Mar 19, 2020
@GrabYourPitchforks GrabYourPitchforks removed the untriaged New issue has not been triaged by the area owner label Mar 19, 2020
@GrabYourPitchforks GrabYourPitchforks self-assigned this Mar 19, 2020
@GrabYourPitchforks GrabYourPitchforks modified the milestones: 5.0.0, Future Aug 12, 2020
@GrabYourPitchforks GrabYourPitchforks removed their assignment Nov 12, 2020
@steveharter steveharter modified the milestones: Future, 6.0.0 Nov 12, 2020
@BartoszKlonowski
Copy link
Contributor

@GrabYourPitchforks I would like to work on that, so please assign me to this issue.
CC: @steveharter @krwq

@krwq
Copy link
Member

krwq commented Jul 8, 2021

Hey @BartoszKlonowski are you still planning to work on this issue? In the meanwhile I'll change milestone as it's not critical for 6.0

@krwq krwq modified the milestones: 6.0.0, 7.0.0 Jul 8, 2021
@BartoszKlonowski
Copy link
Contributor

@krwq Yes, and sorry for the delay. I had it planned for this week, but it turned out to be busier then I thought.
It will for sure be delivered within next week.

@BartoszKlonowski
Copy link
Contributor

@krwq Unfortunately I need to postpone my work on this as I currently don't have enough time to spend to deep into this, sorry for inconvenience.

@ghost ghost added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Aug 3, 2021
@GrabYourPitchforks
Copy link
Member Author

Thanks for the heads up @BartoszKlonowski! I think we all understand busy schedules interfering with these things. :)

@BartoszKlonowski BartoszKlonowski removed their assignment Aug 3, 2021
@buyaa-n buyaa-n removed the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Aug 5, 2021
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 10, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants