-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broke ability to use RuntimeFlavor in local builds #23800
Labels
Comments
jaredpar
added a commit
that referenced
this issue
Jan 31, 2020
Our logic for setting the CoreCLR and Mono runtime configurations didn't properly account for cases where only `$(Configuration)` was passed down as a build property. It expects that both `$(Configuration)` and `$(ConfigurationGroup)` are passed down as a pair. This change guards against us accidentially setting the runtime configuration to the current library definition of configuration which is more like a target framework than Debug or Release. Related to #23800
jaredpar
added a commit
that referenced
this issue
Jan 31, 2020
* Account for missing ConfigurationGroup Our logic for setting the CoreCLR and Mono runtime configurations didn't properly account for cases where only `$(Configuration)` was passed down as a build property. It expects that both `$(Configuration)` and `$(ConfigurationGroup)` are passed down as a pair. This change guards against us accidentially setting the runtime configuration to the current library definition of configuration which is more like a target framework than Debug or Release. Related to #23800 * Test for missing ConfigurationGroup
Is there still something to be done after #24077? seems to be working here. |
I was keeping it open for the second part of the issue
That's a separate issue. Can track separately. |
ghost
locked as resolved and limited conversation to collaborators
Dec 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Execute the following command:
Will lead to the following error:
There are two issues at hand here that need to be addressed:
$(Configuration)
is set but$(ConfigurationGroup)
is not.This was a regression introduced with #2093. That means we have the following chain of sadness: PR #1934 leads to runtime config breaks leads to #2093 which leads to this.
The text was updated successfully, but these errors were encountered: