Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable System.Resources.Extensions.BinaryFormat.Tests test project #103447

Closed
bartonjs opened this issue Jun 13, 2024 · 1 comment · Fixed by #104104
Closed

Re-enable System.Resources.Extensions.BinaryFormat.Tests test project #103447

bartonjs opened this issue Jun 13, 2024 · 1 comment · Fixed by #104104
Assignees
@adamsitnik
Labels
area-System.Resources binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it
Milestone
9.0.0

Comments

@bartonjs
Copy link
Member

The tests use BinaryFormatter to genenerate data to test the new resource deserializer. Since BinaryFormatter is now disabled, and the compact NuGet package isn't available yet, they have to be turned off in transition.
@bartonjs bartonjs added blocked Issue/PR is blocked on something - see comments binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it labels Jun 13, 2024
@bartonjs bartonjs added this to the 9.0.0 milestone Jun 13, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 13, 2024
@vcsjones vcsjones added area-System.Resources and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-resources
See info in area-owners.md if you want to be subscribed.

adamsitnik added a commit to adamsitnik/runtime that referenced this issue Jun 27, 2024
@adamsitnik
re-enable BinaryFormatter tests, fixes dotnet#103447
79f1c5e
@adamsitnik adamsitnik mentioned this issue Jun 27, 2024
Merged
@adamsitnik adamsitnik self-assigned this Jun 28, 2024
@adamsitnik adamsitnik removed the blocked Issue/PR is blocked on something - see comments label Jun 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamsitnik adamsitnik

Labels
area-System.Resources binaryformatter-migration Issues related to the removal of BinaryFormatter and migrations away from it
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

re-enable BinaryFormatter tests, fixes #103447 adamsitnik/runtime
3 participants
@vcsjones @adamsitnik @bartonjs