Always clear the local buffer in ArrayBuffer (#49573)

- SslStream was holding onto a 4K byte[] after the handshake was complete. This was because the ArrayBuffer struct doesn't clear the local buffer field in dispose. This changes that.
dotnet · Mar 29, 2021 · 102d1e8 · 102d1e8
1 parent 21734a4
commit 102d1e8
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/src/libraries/Common/src/System/Net/ArrayBuffer.cs b/src/libraries/Common/src/System/Net/ArrayBuffer.cs
@@ -41,15 +41,12 @@ public void Dispose()
             _activeStart = 0;
             _availableStart = 0;
 
-            if (_usePool)
-            {
-                byte[] array = _bytes;
-                _bytes = null!;
+            byte[] array = _bytes;
+            _bytes = null!;
 
-                if (array != null)
-                {
-                    ArrayPool<byte>.Shared.Return(array);
-                }
+            if (_usePool && array != null)
+            {
+                ArrayPool<byte>.Shared.Return(array);
             }
         }