Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LSP handler for copilot related documents #74918

Merged
merged 13 commits into from
Aug 28, 2024
Merged

Add LSP handler for copilot related documents #74918

merged 13 commits into from
Aug 28, 2024

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Aug 27, 2024 •
edited
Loading

Followup to #74906.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Aug 27, 2024
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Aug 27, 2024
Merged
@build-analysis build-analysis bot mentioned this pull request Aug 27, 2024
Open
3 tasks
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review August 28, 2024 04:00
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 28, 2024 04:00
@CyrusNajmabadi
Copy link
Member Author

@dibarbet @genlu this is ready for review.

This was referenced Aug 28, 2024
Open
Open
dibarbet
dibarbet reviewed Aug 28, 2024
View reviewed changes
src/LanguageServer/Protocol/Handler/RelatedDocuments/RelatedDocumentsHandler.cs Show resolved Hide resolved
src/LanguageServer/Protocol/Protocol/Internal/VSInternalRelatedDocumentParams.cs Show resolved Hide resolved
src/LanguageServer/ProtocolUnitTests/RelatedDocuments/RelatedDocumentsTests.cs Show resolved Hide resolved
src/LanguageServer/Protocol/Handler/RelatedDocuments/RelatedDocumentsHandler.cs
public bool MutatesSolutionState => false;
public bool RequiresLSPSolution => true;

private static async Task<(Checksum parseOptionsChecksum, Checksum textChecksum)> ComputeChecksumsAsync(Document document, CancellationToken cancellationToken)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this endpoint invoked as part of a specific user action, or is the client polling us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client polling i believe.

@CyrusNajmabadi
Copy link
Member Author

@genlu @dibarbet ptal :)

@CyrusNajmabadi CyrusNajmabadi merged commit 0ceb056 into dotnet:main Aug 28, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 28, 2024
@CyrusNajmabadi CyrusNajmabadi deleted the relatedDocumentsHandler branch August 28, 2024 22:37
This was referenced Sep 6, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibarbet dibarbet dibarbet approved these changes

@genlu genlu Awaiting requested review from genlu

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
3 participants
@CyrusNajmabadi @genlu @dibarbet