Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brokered service for Hot Reload in VS Code: GenericHotReloadAgentManagerService #74029

Conversation

spadapet
Copy link
Contributor

Adding GenericHotReloadAgentManagerService to the list of brokered services that are registered, allowing use of those services by MAUI Hot Reload in VS Code. This Hot Reload service is proffered by vs-green debugger functionality, implemented in TypeScript there.

This PR is based on a very similar PR:

@spadapet spadapet requested a review from a team as a code owner June 17, 2024 17:01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jun 17, 2024
@spadapet
Copy link
Contributor Author

@dibarbet I'm not able to add specific people as reviewers, but you approved a similar PR. So I'd appreciate if you can take a look at this too. Here was the other one:

cc: @BretJohnson

@spadapet
Copy link
Contributor Author

@dibarbet, @tmat, I don't have permission to re-run the failed checks. Can I either get permission, or request for someone to re-run the checks for me?
Thanks!

@dibarbet dibarbet enabled auto-merge June 17, 2024 23:19
@dibarbet dibarbet merged commit 6653423 into dotnet:main Jun 18, 2024
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 18, 2024
@spadapet spadapet deleted the dev/peterspa/GenericHotReloadAgentManagerService branch June 18, 2024 15:37
@jjonescz jjonescz modified the milestones: Next, 17.11 P3 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants