Fix building executables for language server #71007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
dibarbet
commented
Dec 6, 2023
|
|
||
| So if we don't have a platform, tell the build not to output a .exe file because we're building platform neutral bits. | ||
| --> | ||
| <UseAppHost Condition="'$(RuntimeIdentifier)' == ''">false</UseAppHost> |
There was a problem hiding this comment.
We were checking for the RuntimeIdentifier before it got set. Moved this below and now it works.
|
cc @jasonmalinowski - thoughts on taking this PR? It doesn't fix everything, but IMHO its worth having as
|
jasonmalinowski
approved these changes
Dec 13, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches back to ms.ca.languageserver executable for win/linux (mac still requires the dll due to codesign issues).
Not a perfect solution, but better than before.