Two LSIF tool fixes #70847
Merged
Two LSIF tool fixes #70847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the BuildHost library for serialization types in-proc of the user of MSBuildWorkspace; we include it in the NuGet package but due to the trickiness of having to package it, projects within this repo need to reference the project explicitly.
We emit document symbol spans for any declared type, however the use of a tuple is (reasonably) considered a declaration of that field. But for the purposes of something like a document outline, we don't want that.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
mohaimenhasan
approved these changes
Nov 16, 2023
hjihong
approved these changes
Nov 16, 2023
dibarbet
approved these changes
Nov 16, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BuildHost not being deployed which broke it (and is a build problem unique to our repo), and a bug reported where we were getting tripped up on tuples and anonymous types.