Publish additional packages to vssdk feed #64571
Conversation
| @@ -6,19 +6,19 @@ | |||
| "packages": { | |||
| "default": { | |||
| "Microsoft.CodeAnalysis": "arcade", | |||
| "Microsoft.CodeAnalysis.Common": "arcade", | |||
| "Microsoft.CodeAnalysis.Common": "vssdk", | |||
There was a problem hiding this comment.
hmm this will stop publishing these via arcade I think. Is that OK? Feels like we still need to publish them to the dotnet feeds.
There was a problem hiding this comment.
All our packages are always published by Arcade to the dotnet-tools feed. This should additionally publish it to vssdk.
There was a problem hiding this comment.
Take EditorFeatures for example which is also configured as "vssdk". https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-tools/NuGet/Microsoft.CodeAnalysis.EditorFeatures/overview/4.5.0-1.22506.23
eng/config/PublishData.json
Outdated
| @@ -6,19 +6,19 @@ | |||
| "packages": { | |||
| "default": { | |||
| "Microsoft.CodeAnalysis": "arcade", | |||
| "Microsoft.CodeAnalysis.Common": "arcade", | |||
| "Microsoft.CodeAnalysis.Common": "vssdk", | |||
| "Microsoft.CodeAnalysis.Compilers": "arcade", | |||
| "Microsoft.CodeAnalysis.Scripting": "arcade", | |||
| "Microsoft.CodeAnalysis.Scripting.Common": "arcade", | |||
| "Microsoft.CodeAnalysis.Workspaces.Common": "arcade", | |||
There was a problem hiding this comment.
So if you're here, we're going to need a few more to completely move the VS build forward:
- Microsoft.CodeAnalysis.Workspaces.Common
- Microsoft.CodeAnalysis.CSharp.Workspaces
- Microsoft.CodeAnalysis.VisualBasic.Workspaces
- Microsoft.CodeAnalysis.EditorFeatures.Text
- Microsoft.VisualStudio.LanguageServices
That's at least the list from a quick scan of the internal repo; there's probably going a few more too but that's the "obvious" list.
There was a problem hiding this comment.
Let us get them added now
ghost
added this to the 
* upstream/main: (252 commits) Use the source-built version of ref packs and don't use app host when building in source-build (dotnet#64055) Enable rich LSIF hover information. (dotnet#64580) Add ChecksumAlgorithm to project snapshot (dotnet#62840) Utility for uploading artifact on test failure (dotnet#64578) Enable diagnostics Revert "Remove unused TS brace completion code" Publish additional packages to vssdk feed (dotnet#64571) spelling Move check Simplify SymbolKey implementation lint Update publish data to test PR validation fix (dotnet#64559) Simplify Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/SymbolKey/SymbolKey.cs Lint Proper equality checks Update src/Workspaces/Remote/Core/RemoteCallback.cs Revert "Not wait for solution crawler because it can be very busy" Add and use TargetFramework.Net70 (dotnet#64490) Not wait for solution crawler because it can be very busy ...
No description provided.