Only start scanning for task-list items once the Task-List window is actually open. #64543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Oct 6, 2022
| @@ -93,6 +105,35 @@ private async Task StartAsync(Workspace workspace) | |||
| } | |||
| } | |||
|
|
|||
| private async Task WaitUntilTaskListActivatedAsync() | |||
There was a problem hiding this comment.
from Dabid Pugh, this is the correct way to both determine if hte task-list is actually visible, and register to find out if it is visible if not.
dibarbet
approved these changes
Oct 6, 2022
ghost
added this to the 
|
Here is the new insertion with this fix - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/428517#view=discussion. We are working through some infra issues to get it into VS main before evaluating a drop in RPS and then cherry-picking it to 17.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents registering solution-crawler incremental analyzer that just does work that won't even be visible.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1610934