Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to simplified helper extension for reading data from a stream #64476

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Move to simplified helper extension for reading data from a stream #64476

merged 2 commits into from
Oct 4, 2022

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Oct 4, 2022 •
edited
Loading

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 4, 2022 19:32
jasonmalinowski
jasonmalinowski approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure a lot simpler!

@tmat
Copy link
Member

tmat commented Oct 4, 2022 

        // Work around the lack of async stream writing in ObjectWriter, which is required when writing to the RPC

Is there similar API for writing?

Refers to: src/Workspaces/Remote/Core/SolutionAssetProvider.cs:60 in 9bebbb4. [](commit_id = 9bebbb4, deletion_comment = False)

@CyrusNajmabadi
Copy link
Member Author

Is there similar API for writing?

yes. discussing it now offline

@CyrusNajmabadi CyrusNajmabadi merged commit 5a0f087 into dotnet:main Oct 4, 2022
@ghost ghost added this to the Next milestone Oct 4, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the streamExtensions branch October 4, 2022 22:24
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Oct 4, 2022
Merged
@allisonchou allisonchou mentioned this pull request Oct 11, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@tmat tmat Awaiting requested review from tmat

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@CyrusNajmabadi @tmat @AArnott @jasonmalinowski @RikkiGibson