Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of bounds error when doing speculative operations #64454

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

[Fact]
[WorkItem(1541001, "https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1541001")]
[WorkItem(1587699, "https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1587699")]
public async Task TestOutOfBoundsInSyntaxContext1_CSharp()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests serve to at least tell us if we've done something bad in the future. adding one for VB indicated that VB has a similar issue.

Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CyrusNajmabadi CyrusNajmabadi merged commit e4b1440 into dotnet:main Oct 4, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the speculativeOOB branch October 4, 2022 01:35
@ghost ghost added this to the Next milestone Oct 4, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants