Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use new internal API #64449

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Update to use new internal API #64449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...xternalAccess/UnitTesting/SolutionCrawler/AbstractUnitTestingDocumentDifferenceService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ internal abstract class AbstractUnitTestingDocumentDifferenceService : IUnitTest
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...e/Portable/ExternalAccess/UnitTesting/SolutionCrawler/UnitTestingSolutionCrawlerLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public static void LogIncrementalAnalyzerProcessorStatistics(int correlationId,
}
else
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...sting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncDocumentWorkItemQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ protected override bool TryTakeAnyWork_NoLock(
return true;
}

throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}

private DocumentId GetBestDocumentId_NoLock(
Expand Down
2 changes: 1 addition & 1 deletion ...esting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncProjectWorkItemQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ protected override bool TryTakeAnyWork_NoLock(
return true;
}

throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}

protected override bool AddOrReplace_NoLock(UnitTestingWorkItem item)
Expand Down
2 changes: 1 addition & 1 deletion ...s/UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncWorkItemQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ protected static ProjectId GetBestProjectId_NoLock<T>(
return pair.Key;
}

throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...ing/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingIncrementalAnalyzerProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ await RunAnalyzersAsync(analyzers, document, workItem, (analyzer, document, canc
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
}

Expand All @@ -389,7 +389,7 @@ await RunAnalyzersAsync(analyzers, document, workItem, (analyzer, document, canc
catch (Exception e) when (FatalError.ReportAndPropagate(e))
{
// TODO: manage bad workers like what code actions does now
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}

static bool ReportWithoutCrashUnlessAllCanceledAndPropagate(AggregateException aggregate)
Expand Down
4 changes: 2 additions & 2 deletions ...UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingLowPriorityProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ protected override async Task ExecuteAsync()
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
}

Expand Down Expand Up @@ -184,7 +184,7 @@ await Processor.RunAnalyzersAsync(analyzers, project, workItem,
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
finally
{
Expand Down
10 changes: 5 additions & 5 deletions ...tTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingNormalPriorityProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ protected override async Task ExecuteAsync()
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
finally
{
Expand Down Expand Up @@ -298,7 +298,7 @@ private async Task<bool> TryProcessOneHigherPriorityDocumentAsync()
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
}

Expand Down Expand Up @@ -383,7 +383,7 @@ private async Task ProcessDocumentAsync(ImmutableArray<IUnitTestingIncrementalAn
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}
finally
{
Expand Down Expand Up @@ -505,7 +505,7 @@ await Processor.RunAnalyzersAsync(reanalyzers, sourceDocument, workItem,
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}

return;
Expand Down Expand Up @@ -577,7 +577,7 @@ await Processor.RunAnalyzersAsync(
}
catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
{
throw ExceptionUtilities.Unreachable;
throw ExceptionUtilities.Unreachable();
}

return;
Expand Down