Add additional information when we throw an 'unreachable' exception #64402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Sep 30, 2022
| get { return new InvalidOperationException("This program location is thought to be unreachable."); } | ||
| } | ||
| internal static Exception Unreachable([CallerFilePath] string? path = null, [CallerLineNumber] int line = 0) | ||
| => new InvalidOperationException($"This program location is thought to be unreachable. File='{path}' Line={line}"); |
There was a problem hiding this comment.
this is the actual update to the helper property to be a helper method.
jasonmalinowski
approved these changes
Sep 30, 2022
|
@dotnet/roslyn-compiler for this change to help diagnosability of watson dumps for exceptions. |
genlu
approved these changes
Sep 30, 2022
ghost
added this to the
|
ack. did not intend to merge this. |
|
Talking to infra now. |
|
Thanks guys. Sorry for the accidental merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting "unreachable" exceptions that we're finding to difficult to take action on due to trouble determining what the actual throw point of hte exception was. This adds that information to the exception, in a similar way to how we added information to our Contract calls so that devs investigating the issue could track the exception back to the exact location it was thrown.