Add non-strict search flag for legacy unit test providers #64375
Conversation
|
|
||
| private UnitTestingSearchQuery(string fullyQualifiedTypeName, string? methodName, int methodArity, int methodParameterCount) | ||
| private UnitTestingSearchQuery(string fullyQualifiedTypeName, string? methodName, int methodArity, int methodParameterCount, bool strict) |
There was a problem hiding this comment.
One other thing we care about is presence of attributes on the method. Is it possible to introduce a flag to filter out methods that don't have any attributes? (Or perhaps hard code to exclude non-attributed methods when strict is true)
There was a problem hiding this comment.
yes. i'll find a way to add those smarts in.
| if (query.Strict && info.TypeParameterCount != symbolArity) | ||
| continue; | ||
|
|
||
| if (info.Name != symbolName) |
There was a problem hiding this comment.
For VB the name could theoretically be different case. Is it possible to take that into account here?
There was a problem hiding this comment.
Actually never-mind, we'll probably require that the supplied name should match the casing present in the code in such cases. But one potential option may be to allow different casing for VB when strict is false.
There was a problem hiding this comment.
that seems like it would be very odd for the name to not match. but sure, i can add that :)
There was a problem hiding this comment.
Yup doing that with strict=true would certainly be odd. But it would be nice to find closest match with strict=false :)
Note that I am only proposing with behavior when strict=off and also only when the language is VB :)
| } | ||
|
|
||
| // Looking promising so far. Check that the container matches what the caller needs. | ||
| if (info.FullyQualifiedContainerName != container) |
There was a problem hiding this comment.
Same question about case sensitivity for VB
There was a problem hiding this comment.
yup. i'll find a way to handle that.
ghost
added this to the 
This is useful as not all test providers are written with a high degree of quality wrt to the data they produce. This allows our search service to first be called in strict mode to look for precise matches, but then be called in a more relaxed mode of none are found.