Better handle methods in partial classes that don't have sequence points #64337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
force-pushed
the
NavigateToTheRightDocument
branch
from
8886bdb
to
ad7e042
Compare
tmat
reviewed
Sep 28, 2022
src/Features/Core/Portable/PdbSourceDocument/PdbSourceDocumentMetadataAsSourceFileProvider.cs
Show resolved
Hide resolved
This reverts commit b7e9216.
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix all of #59713 but it does improve some scenarios. Basically we weren't correctly navigating the user correctly when there are multiple files, in cases where we had more context about where to navigate to (eg, a method to navigate to) but didn't have specific document info about that (eg, a method with no sequence points). This improves that scenario.
There is still a better fix for that issue though, allowing the user to choose where to navigate to when necessary, so will leave it open, but this should actually fix the issue reported by the customer in https://developercommunity.visualstudio.com/t/F12-on-C-extension-method-partial-clas/10152882