-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy 'todo list' support #64319
Conversation
Do you want to this to be in 17.4? (If so, then target release/dev17.4) |
I don't see any need for this to be in 17.4
Isn't that what this PR from TS is: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103?_a=files ? Do they have a separate insertion process on top of that? |
I think the link you posts is the VS extension for TS right? So I guess they also need to insert their payload to VS in some way. But since it doesn't need to be in 17.4 this won't be a problem yet. Since there is no 17.5 branch in VS, by the time when 17.5 opens we should be fine. |
Ah, i didn't realize that. Thanks! :) |
I agree with everything that @Cosifne said :) https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103 only added TaskList support to our main branch but our insertion into VS happens later. |
TypeScript moved off of the legacy API here: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103?_a=files
So it can be removed safely.