Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy 'todo list' support #64319

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

CyrusNajmabadi
Copy link
Member

TypeScript moved off of the legacy API here: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103?_a=files

So it can be removed safely.

@Cosifne
Copy link
Member

Cosifne commented Sep 27, 2022

Do you want to this to be in 17.4? (If so, then target release/dev17.4)
Also, does this mean we need to wait TS to merge & insert first, and then we insert the change?

@CyrusNajmabadi
Copy link
Member Author

Do you want to this to be in 17.4? (If so, then target release/dev17.4)

I don't see any need for this to be in 17.4

Also, does this mean we need to wait TS to merge & insert first, and then we insert the change?

Isn't that what this PR from TS is: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103?_a=files ?

Do they have a separate insertion process on top of that?

@Cosifne
Copy link
Member

Cosifne commented Sep 27, 2022

Do you want to this to be in 17.4? (If so, then target release/dev17.4)

I don't see any need for this to be in 17.4

Also, does this mean we need to wait TS to merge & insert first, and then we insert the change?

Isn't that what this PR from TS is: https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103?_a=files ?

Do they have a separate insertion process on top of that?

I think the link you posts is the VS extension for TS right? So I guess they also need to insert their payload to VS in some way.
If we inserted this first, and they do it next. There might be some broken builds.

But since it doesn't need to be in 17.4 this won't be a problem yet. Since there is no 17.5 branch in VS, by the time when 17.5 opens we should be fine.

@CyrusNajmabadi
Copy link
Member Author

I think the link you posts is the VS extension for TS right? So I guess they also need to insert their payload to VS in some way.
If we inserted this first, and they do it next. There might be some broken builds.

Ah, i didn't realize that. Thanks! :)

@MariaSolOs
Copy link
Contributor

I agree with everything that @Cosifne said :) https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/424103 only added TaskList support to our main branch but our insertion into VS happens later.

@CyrusNajmabadi CyrusNajmabadi merged commit b887b77 into dotnet:main Sep 27, 2022
@ghost ghost added this to the Next milestone Sep 27, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the removeTodo branch September 27, 2022 19:53
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants