Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ref foreach tests #64276

Merged
merged 4 commits into from
Oct 6, 2022
Merged

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Sep 26, 2022

Closes #64218 as suggested in #64218 (comment).

@jjonescz jjonescz marked this pull request as ready for review September 27, 2022 10:34
@jjonescz jjonescz requested a review from a team as a code owner September 27, 2022 10:34
@jcouv jcouv self-assigned this Sep 27, 2022
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv added the Test Test failures in roslyn-CI label Sep 27, 2022
@jjonescz
Copy link
Member Author

jjonescz commented Oct 3, 2022

@dotnet/roslyn-compiler ready for review

@jcouv jcouv requested a review from AlekseyTs October 5, 2022 23:53
@AlekseyTs
Copy link
Contributor

This is a test-only change that can be merged with a single sign-off, we already have two.

@jjonescz jjonescz merged commit 2af706a into dotnet:main Oct 6, 2022
@ghost ghost added this to the Next milestone Oct 6, 2022
@jjonescz jjonescz deleted the ref-safety-foreach-2 branch October 6, 2022 05:54
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Compilers Test Test failures in roslyn-CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ref safety error inside foreach
5 participants