Merge pull request #64449 from CyrusNajmabadi/mergeFixes

Update to use new internal API
dotnet · Oct 3, 2022 · af24e70 · af24e70
2 parents ef7d1cf + 93753ed
commit af24e70
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/...xternalAccess/UnitTesting/SolutionCrawler/AbstractUnitTestingDocumentDifferenceService.cs b/...xternalAccess/UnitTesting/SolutionCrawler/AbstractUnitTestingDocumentDifferenceService.cs
@@ -96,7 +96,7 @@ internal abstract class AbstractUnitTestingDocumentDifferenceService : IUnitTest
             }
             catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
             {
-                throw ExceptionUtilities.Unreachable;
+                throw ExceptionUtilities.Unreachable();
             }
         }
 

diff --git a/...e/Portable/ExternalAccess/UnitTesting/SolutionCrawler/UnitTestingSolutionCrawlerLogger.cs b/...e/Portable/ExternalAccess/UnitTesting/SolutionCrawler/UnitTestingSolutionCrawlerLogger.cs
@@ -212,7 +212,7 @@ public static void LogIncrementalAnalyzerProcessorStatistics(int correlationId,
                     }
                     else
                     {
-                        throw ExceptionUtilities.Unreachable;
+                        throw ExceptionUtilities.Unreachable();
                     }
                 }
 

diff --git a/...sting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncDocumentWorkItemQueue.cs b/...sting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncDocumentWorkItemQueue.cs
@@ -71,7 +71,7 @@ protected override bool TryTakeAnyWork_NoLock(
                         return true;
                     }
 
-                    throw ExceptionUtilities.Unreachable;
+                    throw ExceptionUtilities.Unreachable();
                 }
 
                 private DocumentId GetBestDocumentId_NoLock(

diff --git a/...esting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncProjectWorkItemQueue.cs b/...esting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncProjectWorkItemQueue.cs
@@ -74,7 +74,7 @@ protected override bool TryTakeAnyWork_NoLock(
                         return true;
                     }
 
-                    throw ExceptionUtilities.Unreachable;
+                    throw ExceptionUtilities.Unreachable();
                 }
 
                 protected override bool AddOrReplace_NoLock(UnitTestingWorkItem item)

diff --git a/...s/UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncWorkItemQueue.cs b/...s/UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingAsyncWorkItemQueue.cs
@@ -303,7 +303,7 @@ protected static ProjectId GetBestProjectId_NoLock<T>(
                         return pair.Key;
                     }
 
-                    throw ExceptionUtilities.Unreachable;
+                    throw ExceptionUtilities.Unreachable();
                 }
             }
         }

diff --git a/...ing/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingIncrementalAnalyzerProcessor.cs b/...ing/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingIncrementalAnalyzerProcessor.cs
@@ -367,7 +367,7 @@ await RunAnalyzersAsync(analyzers, document, workItem, (analyzer, document, canc
                     }
                     catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
                     {
-                        throw ExceptionUtilities.Unreachable;
+                        throw ExceptionUtilities.Unreachable();
                     }
                 }
 
@@ -389,7 +389,7 @@ await RunAnalyzersAsync(analyzers, document, workItem, (analyzer, document, canc
                     catch (Exception e) when (FatalError.ReportAndPropagate(e))
                     {
                         // TODO: manage bad workers like what code actions does now
-                        throw ExceptionUtilities.Unreachable;
+                        throw ExceptionUtilities.Unreachable();
                     }
 
                     static bool ReportWithoutCrashUnlessAllCanceledAndPropagate(AggregateException aggregate)

diff --git a/...UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingLowPriorityProcessor.cs b/...UnitTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingLowPriorityProcessor.cs
@@ -69,7 +69,7 @@ protected override async Task ExecuteAsync()
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
                     }
 
@@ -184,7 +184,7 @@ await Processor.RunAnalyzersAsync(analyzers, project, workItem,
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
                         finally
                         {

diff --git a/...tTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingNormalPriorityProcessor.cs b/...tTesting/SolutionCrawler/UnitTestingWorkCoordinator.UnitTestingNormalPriorityProcessor.cs
@@ -180,7 +180,7 @@ protected override async Task ExecuteAsync()
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
                         finally
                         {
@@ -298,7 +298,7 @@ private async Task<bool> TryProcessOneHigherPriorityDocumentAsync()
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
                     }
 
@@ -383,7 +383,7 @@ private async Task ProcessDocumentAsync(ImmutableArray<IUnitTestingIncrementalAn
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
                         finally
                         {
@@ -505,7 +505,7 @@ await Processor.RunAnalyzersAsync(reanalyzers, sourceDocument, workItem,
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e, cancellationToken))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
 
                         return;
@@ -577,7 +577,7 @@ await Processor.RunAnalyzersAsync(
                         }
                         catch (Exception e) when (FatalError.ReportAndPropagateUnlessCanceled(e))
                         {
-                            throw ExceptionUtilities.Unreachable;
+                            throw ExceptionUtilities.Unreachable();
                         }
 
                         return;