Add support for catching incorrect usage/registration of Operation ac… #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions in our meta analyzers (analyzers for correct implementation of analyzers). Fixes dotnet#737
|
Tagging @dotnet/roslyn-analysis for review. |
|
Also tagging @JohnHamby as an FYI |
|
Ping? |
|
Looking now. |
| <data name="MissingKindArgumentToRegisterActionMessage" xml:space="preserve"> | ||
| <value>Specify at least one '{0}' of interest while registering a {1} analyzer action.</value> | ||
| <data name="MissingSymbolKindArgumentToRegisterActionMessage" xml:space="preserve"> | ||
| <value>Specify at least one SymbolKind of interest while registering a symbol analyzer action.</value> |
There was a problem hiding this comment.
"while registering" => "when registering"
|
Mostly nitpicks, but please see my comment on Core/MetaAnalyzers/RegisterActionAnalyzer.cs before I sign off. |
|
👍 |
|
@lgolding I have pushed another commit addressing your feedback - thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions in our meta analyzers (analyzers for correct implementation of analyzers).
Fixes #737