Don't raise CA1849 when async version has fewer parameters #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7318 +/- ##
========================================
Coverage 96.47% 96.48%
========================================
Files 1443 1443
Lines 345400 345483 +83
Branches 11364 11365 +1
========================================
+ Hits 333239 333350 +111
+ Misses 9282 9256 -26
+ Partials 2879 2877 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected analyzer: UseAsyncMethodInAsyncContext
Affected diagnostic ID: CA1849
This PR prevents CA1849 being raised when the async alternative has fewer parameters than the sync method.
Fixes #7289