Improve CA1305 for nullable types #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7306 +/- ##
=======================================
Coverage 96.47% 96.48%
=======================================
Files 1443 1443
Lines 345400 345408 +8
Branches 11364 11362 -2
=======================================
+ Hits 333239 333251 +12
+ Misses 9282 9279 -3
+ Partials 2879 2878 -1 |
buyaa-n
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected analyzer: SpecifyIFormatProviderAnalyzer
Affected diagnostic IDs: CA1305
This PR improves nullable support for CA1305. So far only nullable number types were analyzed, this is now extended to all nullables.