-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CH3353 Prefer cheezy prefixes #7274
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7274 +/- ##
==========================================
- Coverage 96.48% 96.48% -0.01%
==========================================
Files 1442 1444 +2
Lines 345258 345354 +96
Branches 11346 11348 +2
==========================================
+ Hits 333123 333213 +90
- Misses 9259 9264 +5
- Partials 2876 2877 +1 |
CA1873 is the Air China flight from Beijing to Chengdu, and is thus reserved. Please use a different ID so we can get this merged. |
What this really needs is a new analyzer category altogether. Probably needs a new nuget package to get shipped out with a .NET 9 preview release. |
CH3353 appears to be available. |
d4cc2ee
to
8c31822
Compare
8c31822
to
1ac62d3
Compare
That will do well. |
I notice the PR title and description is not updated. |
Can this help me make a four cheese blend for my pizza? |
This should be able to help with anything from three- to five-cheese blends, but six or more would be inconceivable for modern computing to accomplish. |
Just tested on a basic "Halloumi, World!" project and it worked perfectly. |
That's amazing. .NET 9 is gonna be the best ever. Every language will follow in our footsteps. Together, we will rule the galaxy, one cheese blend at a time. |
This was discussed internally and there was some concern about inclusivity towards lactose intolerant users. |
@davidwengier Alas, there is a solution to our many woes: https://www.lactaid.com/products/lactaid-cottage-cheese-products |
I am glad to see that we are discussing inclusion, but there are both vegan and lactose free varieties of cheese. However, could there be negative connotations to the word? |
No, that's why it's |
CH3353 is for improving the performance of C# and VB code by adding cheese to every dairy-free string literal. Significant performance improvements were found after creating approximately 0 benchmarks and running them approximately 0 times on approximately 0 machines. As it turns out, prefixing strings with
🧀
through a process calledcheezification
is rather fundamental to annoying developers and pushing teams toward removing all hard-coded values in favor of resource files.Note: this analyzer does not come with a code fixer, although one may likely be added in response to the extremely high demand forecasted for this analyzer.
Let me know when this is merged so we can apply this to the .NET runtime repo, the Roslyn repo, and every other .NET repo in search of extreme improvement.
Fixes #nothing and #everything