Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA1854: Use unused variable name for out parameter #7261

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Mar 22, 2024

Fixes #6022.

This commit also adds a new convenience extension method for other
fixers to use.
@mpidash mpidash requested a review from a team as a code owner March 22, 2024 21:12
@mpidash mpidash closed this Jul 5, 2024
@mpidash mpidash reopened this Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (48136f7) to head (7d6ad88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7261   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files        1443     1443           
  Lines      345946   345964   +18     
  Branches    11383    11385    +2     
=======================================
+ Hits       333829   333849   +20     
+ Misses       9236     9234    -2     
  Partials     2881     2881           

Copy link
Member

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @mpidash, looks it needs running build with -pack to fix the build failure caused by generated docs

@mpidash
Copy link
Contributor Author

mpidash commented Aug 24, 2024

@buyaa-n It seems that the documentation file in main is broken (incorrectly marks CA5360 as missing documentation). I fixed the build here and the merge should fix it in main.

@buyaa-n buyaa-n merged commit e362b92 into dotnet:main Aug 26, 2024
11 checks passed
@mpidash mpidash deleted the issue-6022 branch August 26, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CA1854 Improve suggested variable name and/or type of the fixer
2 participants